Bug 213161 – [IPC hardening] Return type of -[NSCoder validateClassSupportsSecureCoding:] is incorrect

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[David Kilzer (:ddkilzer)]

Return type of -[NSCoder validateClassSupportsSecureCoding:] is incorrect.

It's currently defined as void, but should be BOOL.

[David Kilzer (:ddkilzer)]

<rdar://problem/64050085>

[David Kilzer (:ddkilzer)]

Created attachment 401820 [details]
Patch v1

[Darin Adler]

Comment on attachment 401820 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=401820&action=review

> Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm:642
> +    ASSERT_UNUSED(result, result);

Wait, shouldn’t this be raising an exception instead of ignoring it, if the value returned is false?

[David Kilzer (:ddkilzer)]

Comment on attachment 401820 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=401820&action=review

>> Source/WebKit/Shared/API/Cocoa/WKRemoteObjectCoder.mm:642
>> +    ASSERT_UNUSED(result, result);
> 
> Wait, shouldn’t this be raising an exception instead of ignoring it, if the value returned is false?

The -validateClassSupportsSecureCoding: method currently throws an NSException before returning NO, but that behavior is configurable, so yes, WebKit should also throw just in case that gets turned off unexpectedly.

[David Kilzer (:ddkilzer)]

Created attachment 401875 [details]
Patch v2

[EWS]

Committed r263016: <https://trac.webkit.org/changeset/263016>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401875 [details].