Bug 213145 – [iOS] Preferences are not being observed if the process pool is being created after activation

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Per Arne Vollan]

If the app is creating the Web process pool after being activated, preferences will not be observed until the app is being backgrounded and then foregrounded again, since the preference observer is initialized when handling the app activation notification.

[Per Arne Vollan]

rdar://problem/63720477

[Per Arne Vollan]

Created attachment 401774 [details]
Patch

[Per Arne Vollan]

Created attachment 401778 [details]
Patch

[Brent Fulgham]

Comment on attachment 401778 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401778&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:474
> +            startObservingPreferenceChanges();

Do we need to do anything special to stop observing preferences in this case? Or is it handled automatically by the normal code paths?

[Per Arne Vollan]

Created attachment 401782 [details]
Patch

[Per Arne Vollan]

Created attachment 401783 [details]
Patch

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #4)
> Comment on attachment 401778 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401778&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:474
> > +            startObservingPreferenceChanges();
> 
> Do we need to do anything special to stop observing preferences in this
> case? Or is it handled automatically by the normal code paths?

Actually, we will observe preference changes during the full lifetime of the UI process.

Thanks for reviewing!

[EWS]

Committed r262984: <https://trac.webkit.org/changeset/262984>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401782 [details].