Bug 213140 - compare-results should have an option to print a breakdown and to save the breakdown as csv file
Summary: compare-results should have an option to print a breakdown and to save the br...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-12 11:17 PDT by Saam Barati
Modified: 2020-06-13 13:21 PDT (History)
3 users (show)

See Also:


Attachments
patch (13.51 KB, patch)
2020-06-12 18:06 PDT, Saam Barati
no flags Details | Formatted Diff | Diff
patch (13.53 KB, patch)
2020-06-12 19:07 PDT, Saam Barati
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-06-12 11:17:07 PDT
...
Comment 1 Saam Barati 2020-06-12 18:06:15 PDT
Created attachment 401814 [details]
patch
Comment 2 Keith Miller 2020-06-12 18:46:15 PDT
Comment on attachment 401814 [details]
patch

Code seems reasonable to me. I'll need to reread the maths though... >.>
Comment 3 Saam Barati 2020-06-12 19:07:30 PDT
Created attachment 401819 [details]
patch
Comment 4 EWS 2020-06-13 13:20:37 PDT
Committed r263005: <https://trac.webkit.org/changeset/263005>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401819 [details].
Comment 5 Radar WebKit Bug Importer 2020-06-13 13:21:17 PDT
<rdar://problem/64332043>