Bug 213135 - REGRESSION(r261985): Unable to respond to large comments on Bugzilla with always-on scrollbars
Summary: REGRESSION(r261985): Unable to respond to large comments on Bugzilla with alw...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks: 212168
  Show dependency tree / graph
 
Reported: 2020-06-12 10:01 PDT by Chris Dumez
Modified: 2020-06-12 23:13 PDT (History)
12 users (show)

See Also:

Attachments
Patch (14.56 KB, patch)
2020-06-12 21:07 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-06-12 10:01:53 PDT 
Unable to respond to large comments on Bugzilla:
1. Go to https://bugs.webkit.org/show_bug.cgi?id=212981
2. Click the "Reply" link next to comment #14
-> Notice that the page hangs
Comment 1 Chris Dumez 2020-06-12 10:02:40 PDT 
This is a recent regression, I am trying to bisect now.
Comment 2 Chris Dumez 2020-06-12 10:04:01 PDT 
Current regression range:
http://trac.webkit.org/log/trunk/?mode=follow_copy&rev=262244&stop_rev=261979
Comment 4 Radar WebKit Bug Importer 2020-06-12 10:18:55 PDT 
<rdar://problem/64302086>
Comment 5 Chris Dumez 2020-06-12 10:19:07 PDT 
Confirmed regression from Simon's http://trac.webkit.org/changeset/261985/webkit.
Comment 6 Simon Fraser (smfr) 2020-06-12 13:49:33 PDT 
We programmatically scroll on the main thread to reveal the text field, and then AsyncScrollingCoordinator::synchronizeStateFromScrollingTree() clobbers that scroll offset with the current state of the scrolling tree.
Comment 7 Simon Fraser (smfr) 2020-06-12 21:07:51 PDT 
Created attachment 401824 [details]
Patch
Comment 8 EWS 2020-06-12 23:13:17 PDT 
Committed r262996: <https://trac.webkit.org/changeset/262996>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401824 [details].