WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
21313
wtf/ThreadingWin.cpp expects pthreads
https://bugs.webkit.org/show_bug.cgi?id=21313
Summary
wtf/ThreadingWin.cpp expects pthreads
Tony Chang
Reported
2008-10-02 12:39:46 PDT
This is causing a problem for Chromium because it doesn't use pthreads. Patch coming up...
Attachments
[1/2] Chromium doesn't use pthreads on windows, so make its use conditional.
(1.26 KB, patch)
2008-10-02 12:57 PDT
,
Tony Chang
ap
: review+
Details
Formatted Diff
Diff
[2/2] update changelog
(722 bytes, patch)
2008-10-02 12:57 PDT
,
Tony Chang
ap
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Tony Chang
Comment 1
2008-10-02 12:57:17 PDT
Created
attachment 24026
[details]
[1/2] Chromium doesn't use pthreads on windows, so make its use conditional. Also convert a WORD to a DWORD to avoid a compiler warning. This matches the other methods around it. --- JavaScriptCore/wtf/ThreadingWin.cpp | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
Tony Chang
Comment 2
2008-10-02 12:57:18 PDT
Created
attachment 24027
[details]
[2/2] update changelog JavaScriptCore/ChangeLog | 13 +++++++++++++ 1 files changed, 13 insertions(+), 0 deletions(-)
Alexey Proskuryakov
Comment 3
2008-10-02 13:47:44 PDT
Comment on
attachment 24026
[details]
[1/2] Chromium doesn't use pthreads on windows, so make its use conditional. r=me
Alexey Proskuryakov
Comment 4
2008-10-02 13:48:50 PDT
Comment on
attachment 24027
[details]
[2/2] update changelog r=me In the future, please submit patches as a single file, as this makes both reviewing and landing easier.
Eric Seidel (no email)
Comment 5
2008-10-06 18:22:02 PDT
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M JavaScriptCore/ChangeLog M JavaScriptCore/wtf/ThreadingWin.cpp Committed
r37364
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug