Bug 21313 - wtf/ThreadingWin.cpp expects pthreads
Summary: wtf/ThreadingWin.cpp expects pthreads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-02 12:39 PDT by Tony Chang
Modified: 2008-10-06 18:22 PDT (History)
0 users

See Also:


Attachments
[1/2] Chromium doesn't use pthreads on windows, so make its use conditional. (1.26 KB, patch)
2008-10-02 12:57 PDT, Tony Chang
ap: review+
Details | Formatted Diff | Diff
[2/2] update changelog (722 bytes, patch)
2008-10-02 12:57 PDT, Tony Chang
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2008-10-02 12:39:46 PDT
This is causing a problem for Chromium because it doesn't use pthreads.

Patch coming up...
Comment 1 Tony Chang 2008-10-02 12:57:17 PDT
Created attachment 24026 [details]
[1/2] Chromium doesn't use pthreads on windows, so make its use conditional.


Also convert a WORD to a DWORD to avoid a compiler warning.  This
matches the other methods around it.
---
 JavaScriptCore/wtf/ThreadingWin.cpp |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Comment 2 Tony Chang 2008-10-02 12:57:18 PDT
Created attachment 24027 [details]
[2/2] update changelog

 JavaScriptCore/ChangeLog |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)
Comment 3 Alexey Proskuryakov 2008-10-02 13:47:44 PDT
Comment on attachment 24026 [details]
[1/2] Chromium doesn't use pthreads on windows, so make its use conditional.

r=me
Comment 4 Alexey Proskuryakov 2008-10-02 13:48:50 PDT
Comment on attachment 24027 [details]
[2/2] update changelog

r=me

In the future, please submit patches as a single file, as this makes both reviewing and landing easier.
Comment 5 Eric Seidel (no email) 2008-10-06 18:22:02 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/wtf/ThreadingWin.cpp
Committed r37364