Bug 213126 - Simplify MediaRecorderPrivateWriterCocoa threading logic
Summary: Simplify MediaRecorderPrivateWriterCocoa threading logic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-12 07:50 PDT by youenn fablet
Modified: 2020-06-15 02:20 PDT (History)
8 users (show)

See Also:

Attachments
Patch (13.51 KB, patch)
2020-06-12 08:18 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (13.51 KB, patch)
2020-06-15 01:28 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-06-12 07:50:33 PDT 
Simplify MediaRecorderPrivateWriterCocoa threading logic
Comment 1 youenn fablet 2020-06-12 08:18:17 PDT 
Created attachment 401729 [details]
Patch
Comment 2 Eric Carlson 2020-06-12 10:29:27 PDT 
Comment on attachment 401729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401729&action=review

> Source/WebCore/ChangeLog:12
> +        In that case, when stopping recording, the samples will be pushed and we will start the writer.e

s/writer.e/writer/
Comment 3 youenn fablet 2020-06-15 01:28:08 PDT 
Created attachment 401886 [details]
Patch for landing
Comment 4 EWS 2020-06-15 02:19:35 PDT 
Committed r263026: <https://trac.webkit.org/changeset/263026>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401886 [details].
Comment 5 Radar WebKit Bug Importer 2020-06-15 02:20:24 PDT 
<rdar://problem/64355374>