Bug 213119 - Remove FileError.{h,cpp} after bug 213117
Summary: Remove FileError.{h,cpp} after bug 213117
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 213117
Blocks: 213168
  Show dependency treegraph
 
Reported: 2020-06-12 02:37 PDT by Tetsuharu Ohzeki [UTC+9]
Modified: 2020-06-13 11:06 PDT (History)
17 users (show)

See Also:


Attachments
Patch (34.76 KB, patch)
2020-06-12 12:54 PDT, Tetsuharu Ohzeki [UTC+9]
no flags Details | Formatted Diff | Diff
Patch (33.45 KB, patch)
2020-06-13 05:57 PDT, Tetsuharu Ohzeki [UTC+9]
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tetsuharu Ohzeki [UTC+9] 2020-06-12 02:37:32 PDT
This is clean up.
Comment 1 Tetsuharu Ohzeki [UTC+9] 2020-06-12 12:54:37 PDT
Created attachment 401767 [details]
Patch
Comment 2 Chris Dumez 2020-06-12 13:32:14 PDT
Comment on attachment 401767 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401767&action=review

r=me with nits.

> Source/WebCore/fileapi/BlobLoader.h:60
> +    Optional<ExceptionCode> m_errorCode { WTF::nullopt };

{ WTF::nullopt } is unnecessary.

> Source/WebCore/fileapi/FileReaderLoader.cpp:123
> +    if (m_errorCode.hasValue()) {

.hasValue() should not be necessary.

> Source/WebCore/fileapi/FileReaderLoader.cpp:172
> +    if (m_errorCode.hasValue())

ditto.

> Source/WebCore/fileapi/FileReaderLoader.cpp:232
> +    if (m_errorCode.hasValue() && m_errorCode.value() == AbortError)

ditto.

> Source/WebCore/fileapi/FileReaderLoader.cpp:271
> +    if (!m_rawData || m_errorCode.hasValue())

ditto.

> Source/WebCore/fileapi/FileReaderLoader.cpp:287
> +    if (!m_rawData || m_errorCode.hasValue())

ditto.

> Source/WebCore/fileapi/FileReaderLoader.h:121
> +    Optional<ExceptionCode> m_errorCode { WTF::nullopt };

{ WTF::nullopt } is not needed.

> Source/WebCore/fileapi/FileReaderSync.cpp:79
> +    if (!error.hasValue())

.hasValue() is not needed.

> Source/WebCore/fileapi/NetworkSendQueue.cpp:89
> +            if (loader->isLoading() || (errorCode.hasValue() && errorCode.value() == AbortError)) {

.hasValue() is not needed.

> Source/WebCore/fileapi/NetworkSendQueue.cpp:98
> +            ASSERT(errorCode.hasValue());

.hasValue() is not needed.
Comment 3 Tetsuharu Ohzeki [UTC+9] 2020-06-13 05:57:21 PDT
Created attachment 401834 [details]
Patch
Comment 4 EWS 2020-06-13 09:24:19 PDT
Committed r262999: <https://trac.webkit.org/changeset/262999>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401834 [details].
Comment 5 Radar WebKit Bug Importer 2020-06-13 09:25:17 PDT
<rdar://problem/64329711>