RESOLVED FIXED213111
[LFC][TFC] Add support for min/max-width 
https://bugs.webkit.org/show_bug.cgi?id=213111
Summary [LFC][TFC] Add support for min/max-width
alan
Reported 2020-06-11 20:53:21 PDT
ssia
Attachments
Patch (14.44 KB, patch)
2020-06-11 21:28 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (15.24 KB, patch)
2020-06-12 08:16 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2020-06-11 21:28:04 PDT
Created attachment 401705 [details] Patch
Antti Koivisto
Comment 2 2020-06-12 07:13:00 PDT
Comment on attachment 401705 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401705&action=review > Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp:401 > +ContentWidthAndMargin BlockFormattingContext::computedWidthAndMargin(const FloatingContext& floatingContext, const Box& layoutBox, const ConstraintsPair& constraintsPair) It is somewhat confusing to have both 'computeWidthAndMargin' and 'computedWidthAndMargin' functions. Maybe this could be 'computeContentWidthAndMargin' based on the return type?
alan
Comment 3 2020-06-12 07:20:04 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 401705 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401705&action=review > > > Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp:401 > > +ContentWidthAndMargin BlockFormattingContext::computedWidthAndMargin(const FloatingContext& floatingContext, const Box& layoutBox, const ConstraintsPair& constraintsPair) > > It is somewhat confusing to have both 'computeWidthAndMargin' and > 'computedWidthAndMargin' functions. > > Maybe this could be 'computeContentWidthAndMargin' based on the return type? Good point. I think what I am going to do is move this function to geometry() where all the other computed* functions are. That would be inline with the current naming logic: *FormattingContext has the "void compute*" functions and they call the corresponding "Type Geometry::computed*" functions.
alan
Comment 4 2020-06-12 08:16:47 PDT
Created attachment 401728 [details] Patch
EWS
Comment 5 2020-06-12 08:55:07 PDT
Committed r262951: <https://trac.webkit.org/changeset/262951> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401728 [details].
Radar WebKit Bug Importer
Comment 6 2020-06-12 08:56:23 PDT
<rdar://problem/64298644>
Note You need to log in before you can comment on or make changes to this bug.