Bug 213069 – [JSC] Return DisposableCallSiteIndex when destroying GCAwareJITStubRoutineWithExceptionHandler

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[JSC] Return DisposableCallSiteIndex when destroying GCAwareJITStubRoutineWithExceptionHandler

[Yusuke Suzuki]

Created attachment 401622 [details]
Patch

[Yusuke Suzuki]

<rdar://problem/64205186>

[Yusuke Suzuki]

Comment on attachment 401622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401622&action=review

> Source/JavaScriptCore/dfg/DFGCodeOriginPool.h:51
> +    HashSet<unsigned, WTF::IntHash<unsigned>, WTF::UnsignedWithZeroKeyHashTraits<unsigned>> m_callSiteIndexFreeList;

I don't know why it is HashSet. Maybe, we can just make it Vector.

[Yusuke Suzuki]

Created attachment 401624 [details]
Patch

[Yusuke Suzuki]

mac-debug-wk1 is recently crashing. https://results.webkit.org/?suite=layout-tests&test=js%2Fdom%2Fpromise-stack-overflow.html And it seems that crash is unrelated to this.

https://build.webkit.org/results/Apple-Catalina-Release-WK1-Tests/r262781%20(6547)/js/dom/promise-stack-overflow-crash-log.txt

[Saam Barati]

Comment on attachment 401624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401624&action=review

> Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp:132
> +    m_codeOriginPool = nullptr;

When is this function called?

[Yusuke Suzuki]

Comment on attachment 401624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401624&action=review

>> Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp:132
>> +    m_codeOriginPool = nullptr;
> 
> When is this function called?

This function is called when CodeBlock is destroying whole JIT related data.

1. CodeBlock itself is getting destroyed.
2. Destroying entire JITData via resetJITData

So, we can just make it nullptr, since everything will be destroyed.

[Saam Barati]

Comment on attachment 401624 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401624&action=review

r=me

>>> Source/JavaScriptCore/jit/GCAwareJITStubRoutine.cpp:132
>>> +    m_codeOriginPool = nullptr;
>> 
>> When is this function called?
> 
> This function is called when CodeBlock is destroying whole JIT related data.
> 
> 1. CodeBlock itself is getting destroyed.
> 2. Destroying entire JITData via resetJITData
> 
> So, we can just make it nullptr, since everything will be destroyed.

Right. That's what I remembered, just wanted to make sure.

[EWS]

Committed r262920: <https://trac.webkit.org/changeset/262920>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401624 [details].