Bug 213050 - [Cocoa] Return early from preference change notification handler if there is no observer
Summary: [Cocoa] Return early from preference change notification handler if there is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-10 14:47 PDT by Per Arne Vollan
Modified: 2020-06-10 15:35 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.99 KB, patch)
2020-06-10 14:49 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-06-10 14:47:06 PDT 
Currently, the observer member is checked inside the loop iterating over all the keys, but this check should be moved outside of the loop.
Comment 1 Per Arne Vollan 2020-06-10 14:49:03 PDT 
Created attachment 401586 [details]
Patch
Comment 2 Per Arne Vollan 2020-06-10 15:02:39 PDT 
Comment on attachment 401586 [details]
Patch

Thanks for reviewing!
Comment 3 EWS 2020-06-10 15:34:39 PDT 
Committed r262865: <https://trac.webkit.org/changeset/262865>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401586 [details].
Comment 4 Radar WebKit Bug Importer 2020-06-10 15:35:33 PDT 
<rdar://problem/64227791>