Bug 213048 – Make _WKWebsiteDataStoreConfiguration SPI for HSTS storage to replace _WKProcessPoolConfiguration.hstsStorageDirectory

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Make _WKWebsiteDataStoreConfiguration SPI for HSTS storage to replace _WKProcessPoolConfiguration.hstsStorageDirectory

[Alex Christensen]

Created attachment 401582 [details]
Patch

[Darin Adler]

Comment on attachment 401582 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401582&action=review

> Source/WTF/wtf/PlatformHave.h:413
> +    || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \

Should be:

    || ((PLATFORM(IOS) || PLATFORM(MACCATALYST) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \

As I recently learned from Tim Horton.

[Alex Christensen]

Created attachment 401905 [details]
Patch

[Alex Christensen]

Created attachment 401907 [details]
Patch

[Alex Christensen]

Created attachment 401926 [details]
Patch

[youenn fablet]

Comment on attachment 401926 [details]
Patch

LGTM overall.
Can we add some API tests covering HSTS?

[Alex Christensen]

Unfortunately, manual verification is the best we have right now.  I've tried hard in the past, but HSTS apparently only persists data in sandboxed apps, and it does not persist in a timely manner.

[EWS]

Committed r263724: <https://trac.webkit.org/changeset/263724>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401926 [details].

[Radar WebKit Bug Importer]

<rdar://problem/64922940>

[Yusuke Suzuki]

Re-opened since this is blocked by bug 213781

[David Quesada]

Comment on attachment 401926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401926&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:301
> +        [NSException raise:NSInvalidArgumentException format:@"Cannot set mediaKeysStorageDirectory on a non-persistent _WKWebsiteDataStoreConfiguration."];

This should say `Cannot set hstsStorageDirectory...`

[Alex Christensen]

Created attachment 403435 [details]
patch

[Alex Christensen]

Created attachment 403436 [details]
patch

[EWS]

Committed r263882: <https://trac.webkit.org/changeset/263882>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403436 [details].

[Yusuke Suzuki]

Re-opened since this is blocked by bug 213933

[Alexey Proskuryakov]

This broke the build, reverting. Details in Slack.

[Alex Christensen]

Created attachment 407124 [details]
Patch

[Alex Christensen]

Created attachment 407126 [details]
Patch

[Alex Christensen]

Created attachment 407128 [details]
Patch

[EWS]

Committed r266086: <https://trac.webkit.org/changeset/266086>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407128 [details].

[Alex Christensen]

I requested test SPI in rdar://80550123