Make _WKWebsiteDataStoreConfiguration SPI for HSTS storage to replace _WKProcessPoolConfiguration.hstsStorageDirectory
Created attachment 401582 [details] Patch
Comment on attachment 401582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401582&action=review > Source/WTF/wtf/PlatformHave.h:413 > + || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \ Should be: || ((PLATFORM(IOS) || PLATFORM(MACCATALYST) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \ As I recently learned from Tim Horton.
Created attachment 401905 [details] Patch
Created attachment 401907 [details] Patch
Created attachment 401926 [details] Patch
Comment on attachment 401926 [details] Patch LGTM overall. Can we add some API tests covering HSTS?
Unfortunately, manual verification is the best we have right now. I've tried hard in the past, but HSTS apparently only persists data in sandboxed apps, and it does not persist in a timely manner.
Committed r263724: <https://trac.webkit.org/changeset/263724> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401926 [details].
<rdar://problem/64922940>
Re-opened since this is blocked by bug 213781
Comment on attachment 401926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401926&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKWebsiteDataStoreConfiguration.mm:301 > + [NSException raise:NSInvalidArgumentException format:@"Cannot set mediaKeysStorageDirectory on a non-persistent _WKWebsiteDataStoreConfiguration."]; This should say `Cannot set hstsStorageDirectory...`
Created attachment 403435 [details] patch
Created attachment 403436 [details] patch
Committed r263882: <https://trac.webkit.org/changeset/263882> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403436 [details].
Re-opened since this is blocked by bug 213933
This broke the build, reverting. Details in Slack.
Created attachment 407124 [details] Patch
Created attachment 407126 [details] Patch
Created attachment 407128 [details] Patch
Committed r266086: <https://trac.webkit.org/changeset/266086> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407128 [details].
I requested test SPI in rdar://80550123