Bug 21304 - Stop using a static wrapper map for WebCore JS bindings
Summary: Stop using a static wrapper map for WebCore JS bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-02 04:35 PDT by Alexey Proskuryakov
Modified: 2008-10-02 09:20 PDT (History)
0 users

See Also:


Attachments
proposed patch (90.73 KB, patch)
2008-10-02 05:28 PDT, Alexey Proskuryakov
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2008-10-02 04:35:57 PDT
Need this to make bindings machinery thread-safe, patch forthcoming.
Comment 1 Alexey Proskuryakov 2008-10-02 05:28:17 PDT
Created attachment 24018 [details]
proposed patch
Comment 2 Darin Adler 2008-10-02 09:05:48 PDT
Comment on attachment 24018 [details]
proposed patch

We normally iterate vectors with integers rather than iterators.

r=me
Comment 3 Darin Adler 2008-10-02 09:06:35 PDT
Comment on attachment 24018 [details]
proposed patch

One other thought -- it's a little strange to have a member that's an integer named m_pendingActivity, since an integer is not an activity. A better name might explain what the integer reflects. Maybe just m_pendingActivityCount?
Comment 4 Alexey Proskuryakov 2008-10-02 09:20:19 PDT
Committed revision 37190.

Fixed vector iteration, but didn't see the other comment before landing.