RESOLVED FIXED 21304
Stop using a static wrapper map for WebCore JS bindings 
https://bugs.webkit.org/show_bug.cgi?id=21304
Summary Stop using a static wrapper map for WebCore JS bindings
Alexey Proskuryakov
Reported 2008-10-02 04:35:57 PDT
Need this to make bindings machinery thread-safe, patch forthcoming.
Attachments
proposed patch (90.73 KB, patch)
2008-10-02 05:28 PDT, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2008-10-02 05:28:17 PDT
Created attachment 24018 [details] proposed patch
Darin Adler
Comment 2 2008-10-02 09:05:48 PDT
Comment on attachment 24018 [details] proposed patch We normally iterate vectors with integers rather than iterators. r=me
Darin Adler
Comment 3 2008-10-02 09:06:35 PDT
Comment on attachment 24018 [details] proposed patch One other thought -- it's a little strange to have a member that's an integer named m_pendingActivity, since an integer is not an activity. A better name might explain what the integer reflects. Maybe just m_pendingActivityCount?
Alexey Proskuryakov
Comment 4 2008-10-02 09:20:19 PDT
Committed revision 37190. Fixed vector iteration, but didn't see the other comment before landing.
Note You need to log in before you can comment on or make changes to this bug.