Bug 21303 – [GTK] Scrolling glitches

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Mikael Tennhammar]

The visual area is not updated when auto scrolling.

[Mikael Tennhammar]

Created attachment 24016 [details]
Changes in ScrollViewGtk to have teh view repainted

[Dave Hyatt]

Comment on attachment 24016 [details]
Changes in ScrollViewGtk to have teh view repainted

r=me

Gtk had implemented the update() method incorrectly (when it was never meant to be an invalidate), so I guess this got caused by me fixing that.

[Dave Hyatt]

I landed this with my next round of ScrollView changes in 37198.

[Mikael Tennhammar]

Created attachment 24046 [details]
Fix the repainting of the content when scrolling via the scrollbars

The current code do not make that SccrollView repaint itself. after scroll.
Note For the reviewer! I have only experience from GTK, but it seems clean to call the ScrollView's own method.

[Mikael Tennhammar]

After latest updates of ScrollViewGtk the repainting of the view does not happen.

[Mikael Tennhammar]

Created attachment 24048 [details]
Fix the repainting of the content when scrolling via the scrollbars

The current code do not make that SccrollView repaint itself. after scroll.
Note For the reviewer! I have only experience from GTK, but it seems clean to
call the ScrollView's own method.

This is the same patch as the previous one, but there where some printout in the old one.

[Alp Toker]

Created attachment 24049 [details]
Kill off more of ScrollViewGtk, fix GTK+ rendering issues

 WebCore/ChangeLog                             |   42 ++++++
 WebCore/platform/ScrollView.cpp               |   18 --
 WebCore/platform/ScrollView.h                 |    2 
 WebCore/platform/gtk/ScrollViewGtk.cpp        |  180 +++++++-------------------
 WebCore/platform/gtk/ScrollbarGtk.cpp         |  110 ++++++++++-----
 WebCore/platform/gtk/ScrollbarGtk.h           |    5 
 WebKit/gtk/ChangeLog                          |   28 ++++
 WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp |   50 ++++++-
 WebKit/gtk/webkit/webkitwebview.cpp           |   24 +++
 9 files changed, 263 insertions(+), 196 deletions(-)

So, I took the recent breakage as an opportunity to fix invalidation/repaint issues we've had in the GTK+ port since the early days and kill off the cruft in ScrollViewGtk/ScrollViewPrivate (which are almost dead now).

[Dave Hyatt]

Comment on attachment 24048 [details]
Fix the repainting of the content when scrolling via the scrollbars

Made obsolete by my fixes last night.

[Dave Hyatt]

Comment on attachment 24049 [details]
Kill off more of ScrollViewGtk, fix GTK+ rendering issues

You need to merge this patch to ToT.  I landed a fix for my Gtk autoscroll breakage last night.  I think this patch is better than what I did... you just need to get merged to ToT to get a new patch for review.

[Dave Hyatt]

ScrollbarGtk(ScrollbarClient*, ScrollbarOrientation, ScrollbarControlSize, GtkAdjustment* = 0);

ScrollbarGtk is refcounted, so please make a create method instead and don't make your new constructor public.

[Darin Adler]

Comment on attachment 24016 [details]
Changes in ScrollViewGtk to have teh view repainted

Clearing review flag from this obsolete patch.

[Alp Toker]

Created attachment 24484 [details]
Scrolling fixes

[Dave Hyatt]

Comment on attachment 24484 [details]
Scrolling fixes

r=me

[Alp Toker]

Landed in r37725. (Would still be nice to pick up the ScrollbarGtk cleanup changes some time later, they weren't in the patch.)