Bug 213016 - [buildbot] Add buildAndTest bot for WebKitGTK (GTK4)
Summary: [buildbot] Add buildAndTest bot for WebKitGTK (GTK4)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks: GTK4
  Show dependency treegraph
 
Reported: 2020-06-10 02:18 PDT by Diego Pino
Modified: 2020-11-23 20:12 PST (History)
4 users (show)

See Also:


Attachments
Patch (6.21 KB, patch)
2020-06-10 02:20 PDT, Diego Pino
no flags Details | Formatted Diff | Diff
Patch (6.27 KB, patch)
2020-06-13 03:16 PDT, Diego Pino
no flags Details | Formatted Diff | Diff
Patch (5.72 KB, patch)
2020-07-28 07:42 PDT, Diego Pino
no flags Details | Formatted Diff | Diff
Patch (5.30 KB, patch)
2020-11-12 23:32 PST, Diego Pino
no flags Details | Formatted Diff | Diff
Patch (5.28 KB, patch)
2020-11-15 17:29 PST, Diego Pino
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2020-06-10 02:18:08 PDT
[buildbot] Add buildAndTest bot for WebKitGTK (GTK4)
Comment 1 Diego Pino 2020-06-10 02:20:39 PDT
Created attachment 401524 [details]
Patch
Comment 2 Diego Pino 2020-06-13 03:16:38 PDT
Created attachment 401832 [details]
Patch
Comment 3 Diego Pino 2020-07-28 07:42:54 PDT
Created attachment 405356 [details]
Patch
Comment 4 Carlos Alberto Lopez Perez 2020-08-27 07:07:11 PDT
Comment on attachment 405356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405356&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:89
> +                    { "name": "gtk-linux-bot-16", "platform": "gtk" },

Unfortunately I landed r266208 without realizing about this patch before.
And I already picked gtk-linux-bot-16 in r266208.
Can you please change the worker index number here to gtk-linux-bot-18 ?

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:354
> +                      "slavenames": ["gtk-linux-bot-16"]

Ditto
Comment 5 Diego Pino 2020-11-12 23:32:20 PST
Created attachment 414005 [details]
Patch
Comment 6 Carlos Alberto Lopez Perez 2020-11-13 05:42:35 PST
Comment on attachment 414005 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414005&action=review

> Tools/CISupport/build-webkit-org/factories.py:179
> +class BuildAndTestAllButJSCFactory(TestAllButJSCFactory):
> +    def getProduct(self):
> +        self.addStep(CompileWebKit())

instead of inheriting from TestAllButJSCFactory and re-defining getProduct I would do this instead:

class BuildAndTestAllButJSCFactory(BuildAndTestFactory):
    JSCTestClass = None
Comment 7 Diego Pino 2020-11-15 17:29:09 PST
Created attachment 414185 [details]
Patch
Comment 8 EWS 2020-11-17 22:37:39 PST
Committed r269945: <https://trac.webkit.org/changeset/269945>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 414185 [details].
Comment 9 Radar WebKit Bug Importer 2020-11-17 22:38:18 PST
<rdar://problem/71524618>