Bug 212987 – Build is broken with EVENT_LOOP_TYPE=GLib

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Adrian Perez]

To reproduce, try configuring with one of:

  cmake -DPORT=JSCOnly -DEVENT_LOOP_TYPE=GLib -DENABLE_REMOTE_INSPECTOR=OFF
  cmake -DPORT=JSCOnly -DEVENT_LOOP_TYPE=GLib -DENABLE_REMOTE_INSPECTOR=ON

The code is all there, it seems to be mainly some sources missing from
{WTF,JavaScriptCore}_SOURCES and WTF_PUBLIC_HEADERS.

[Adrian Perez]

FTR, this is something I ran into when checking things for bug #212002
to see whether a JSC context a JSCOnly build would be remotely inspectable.

[Adrian Perez]

Created attachment 401485 [details]
Patch

[Adrian Perez]

(In reply to Adrian Perez from comment #2)
> Created attachment 401485 [details]
> Patch

My understading is that EVENT_LOOP_TYPE=Generic is *not* intended
to work with ENABLE_REMOTE_INSPECTOR=ON, so this patch does not do
any attempt at making that combination of options work.

[Konstantin Tokarev]

Comment on attachment 401485 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401485&action=review

> Source/WTF/wtf/PlatformJSCOnly.cmake:141
> +        ${GIO_UNIX_INCLUDE_DIRS}

It might be better to use alphabetic sorting here like we do for plain file lists, though our style checker doesn't track ordering for variables

[Adrian Perez]

(In reply to Konstantin Tokarev from comment #4)
> Comment on attachment 401485 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401485&action=review
> 
> > Source/WTF/wtf/PlatformJSCOnly.cmake:141
> > +        ${GIO_UNIX_INCLUDE_DIRS}
> 
> It might be better to use alphabetic sorting here like we do for plain file
> lists, though our style checker doesn't track ordering for variables

Sure, I'll sort them before landing… though at some point I would
like to change the FindGLIB.cmake module to use imported targets ;-)

[Adrian Perez]

Created attachment 401770 [details]
Patch for landing

[EWS]

Committed r262973: <https://trac.webkit.org/changeset/262973>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401770 [details].

[Radar WebKit Bug Importer]

<rdar://problem/64310783>