Bug 212987 - Build is broken with EVENT_LOOP_TYPE=GLib
Summary: Build is broken with EVENT_LOOP_TYPE=GLib
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-09 13:25 PDT by Adrian Perez
Modified: 2020-06-12 13:53 PDT (History)
21 users (show)

See Also:


Attachments
Patch (6.69 KB, patch)
2020-06-09 15:39 PDT, Adrian Perez
no flags Details | Formatted Diff | Diff
Patch for landing (6.66 KB, patch)
2020-06-12 13:27 PDT, Adrian Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2020-06-09 13:25:11 PDT
To reproduce, try configuring with one of:

  cmake -DPORT=JSCOnly -DEVENT_LOOP_TYPE=GLib -DENABLE_REMOTE_INSPECTOR=OFF
  cmake -DPORT=JSCOnly -DEVENT_LOOP_TYPE=GLib -DENABLE_REMOTE_INSPECTOR=ON

The code is all there, it seems to be mainly some sources missing from
{WTF,JavaScriptCore}_SOURCES and WTF_PUBLIC_HEADERS.
Comment 1 Adrian Perez 2020-06-09 13:27:53 PDT
FTR, this is something I ran into when checking things for bug #212002
to see whether a JSC context a JSCOnly build would be remotely inspectable.
Comment 2 Adrian Perez 2020-06-09 15:39:29 PDT
Created attachment 401485 [details]
Patch
Comment 3 Adrian Perez 2020-06-09 15:46:23 PDT
(In reply to Adrian Perez from comment #2)
> Created attachment 401485 [details]
> Patch

My understading is that EVENT_LOOP_TYPE=Generic is *not* intended
to work with ENABLE_REMOTE_INSPECTOR=ON, so this patch does not do
any attempt at making that combination of options work.
Comment 4 Konstantin Tokarev 2020-06-11 11:06:59 PDT
Comment on attachment 401485 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401485&action=review

> Source/WTF/wtf/PlatformJSCOnly.cmake:141
> +        ${GIO_UNIX_INCLUDE_DIRS}

It might be better to use alphabetic sorting here like we do for plain file lists, though our style checker doesn't track ordering for variables
Comment 5 Adrian Perez 2020-06-12 12:41:29 PDT
(In reply to Konstantin Tokarev from comment #4)
> Comment on attachment 401485 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401485&action=review
> 
> > Source/WTF/wtf/PlatformJSCOnly.cmake:141
> > +        ${GIO_UNIX_INCLUDE_DIRS}
> 
> It might be better to use alphabetic sorting here like we do for plain file
> lists, though our style checker doesn't track ordering for variables

Sure, I'll sort them before landing… though at some point I would
like to change the FindGLIB.cmake module to use imported targets ;-)
Comment 6 Adrian Perez 2020-06-12 13:27:41 PDT
Created attachment 401770 [details]
Patch for landing
Comment 7 EWS 2020-06-12 13:52:07 PDT
Committed r262973: <https://trac.webkit.org/changeset/262973>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401770 [details].
Comment 8 Radar WebKit Bug Importer 2020-06-12 13:53:16 PDT
<rdar://problem/64310783>