Bug 21298 - Make updateScrollbars cross-platform
Summary: Make updateScrollbars cross-platform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 21083
  Show dependency treegraph
 
Reported: 2008-10-01 23:43 PDT by Dave Hyatt
Modified: 2008-10-02 11:24 PDT (History)
0 users

See Also:


Attachments
Patch (38.25 KB, patch)
2008-10-01 23:46 PDT, Dave Hyatt
hyatt: review-
Details | Formatted Diff | Diff
Patch #2 (58.83 KB, patch)
2008-10-02 00:04 PDT, Dave Hyatt
no flags Details | Formatted Diff | Diff
Patch #3 (58.76 KB, patch)
2008-10-02 00:06 PDT, Dave Hyatt
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2008-10-01 23:43:26 PDT
Make updateScrollbars cross-platform on ScrollView.
Comment 1 Dave Hyatt 2008-10-01 23:46:17 PDT
Created attachment 24007 [details]
Patch
Comment 2 Dave Hyatt 2008-10-01 23:50:24 PDT
Comment on attachment 24007 [details]
Patch

Never mind.  I need to remove more code.
Comment 3 Dave Hyatt 2008-10-02 00:04:58 PDT
Created attachment 24008 [details]
Patch #2
Comment 4 Dave Hyatt 2008-10-02 00:06:43 PDT
Created attachment 24009 [details]
Patch #3
Comment 5 Sam Weinig 2008-10-02 00:38:05 PDT
Comment on attachment 24009 [details]
Patch #3

+        The ScrollView now implement ScrollbarClient, which means that there was a clash of windowClipRect methods from the
s/implement/implements/

+            }
+        }
+        else {
+            scrollsHorizontally = (hScroll == ScrollbarAuto) ? hasHorizontalScrollbar : (hScroll == ScrollbarAlwaysOn);

The else should be on the same line as the }.

+        if (pageStep < 0) pageStep = clientWidth;
This should be on two lines.

+        if (pageStep < 0) pageStep = clientHeight;
As should this

-// FIXME: ScrollViewPrivate will eventually be completely gone.  It's already gone on Mac.
-#if !PLATFORM(MAC)
+// FIXME: ScrollViewPrivate will eventually be completely gone.
I think this #if was incorrectly removed.

Otherwise, looks nice.  r=me.
Comment 6 Dave Hyatt 2008-10-02 11:24:17 PDT
Fixed in r37198.