Bug 212970 – BaseAudioSharedUnit should unmute its clients in case of suspension even if not having any audio unit

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

BaseAudioSharedUnit should unmute its clients in case of suspension even if not having any audio unit

[Radar WebKit Bug Importer]

<rdar://problem/64161891>

[youenn fablet]

Created attachment 401437 [details]
Patch

[Eric Carlson]

Comment on attachment 401437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401437&action=review

> Source/WebCore/ChangeLog:9
> +        This will, in turn, make the BaseAudioSharedUnit to stop and no longer have any audio unit.

s/the BaseAudioSharedUnit to stop/the BaseAudioSharedUnit stop/

> Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:179
> +    ASSERT(!m_producingCount);

Is this backwards?

[youenn fablet]

Comment on attachment 401437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401437&action=review

>> Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:179
>> +    ASSERT(!m_producingCount);
> 
> Is this backwards?

Given the current model, m_producingCount should be zero.
I guess I could remove the if(m_producingCount) check.

[youenn fablet]

Created attachment 401442 [details]
Patch

[Eric Carlson]

Comment on attachment 401442 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401442&action=review

> Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:180
>      if (m_producingCount) {

This is confusing given the assert.

[youenn fablet]

(In reply to Eric Carlson from comment #6)
> Comment on attachment 401442 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401442&action=review
> 
> > Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:180
> >      if (m_producingCount) {
> 
> This is confusing given the assert.

Will remove it in a follow-up

[EWS]

Committed r262798: <https://trac.webkit.org/changeset/262798>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401442 [details].