Bug 212967 – scrollingcoordinator/ios/scroll-position-after-reattach.html is a flaky image failure

• Status: RESOLVED
• Resolution: FIXED
• Component: Compositing

[Antti Koivisto]

flake

[Antti Koivisto]

<rdar://problem/52961406>

[Antti Koivisto]

Created attachment 401434 [details]
patch

[Antoine Quint]

Comment on attachment 401434 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401434&action=review

> LayoutTests/scrollingcoordinator/ios/scroll-position-after-reattach.html:33
>      let removed = outercontent;
>      outercontent.remove();

While you're modifying this test, you can remove the `removed` variable which is useless, `outercontent` can be used.

> LayoutTests/scrollingcoordinator/ios/scroll-position-after-reattach.html:36
> +    await new Promise(requestAnimationFrame);

Since this test is already pulling in `UIHelper`, you can use `UIHelper.animationFrame()`.

[Antti Koivisto]

Comment on attachment 401434 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401434&action=review

>> LayoutTests/scrollingcoordinator/ios/scroll-position-after-reattach.html:33
>>      outercontent.remove();
> 
> While you're modifying this test, you can remove the `removed` variable which is useless, `outercontent` can be used.

You'd think so but 'outercontent' is not a variable. It is an implicit property on window object.

[EWS]

Committed r262789: <https://trac.webkit.org/changeset/262789>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401434 [details].