Bug 212967 - scrollingcoordinator/ios/scroll-position-after-reattach.html is a flaky image failure
Summary: scrollingcoordinator/ios/scroll-position-after-reattach.html is a flaky image...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Compositing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-09 04:27 PDT by Antti Koivisto
Modified: 2020-06-09 05:57 PDT (History)
1 user (show)

See Also:


Attachments
patch (2.44 KB, patch)
2020-06-09 04:32 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2020-06-09 04:27:15 PDT
flake
Comment 1 Antti Koivisto 2020-06-09 04:27:27 PDT
<rdar://problem/52961406>
Comment 2 Antti Koivisto 2020-06-09 04:32:22 PDT
Created attachment 401434 [details]
patch
Comment 3 Antoine Quint 2020-06-09 05:37:57 PDT
Comment on attachment 401434 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401434&action=review

> LayoutTests/scrollingcoordinator/ios/scroll-position-after-reattach.html:33
>      let removed = outercontent;
>      outercontent.remove();

While you're modifying this test, you can remove the `removed` variable which is useless, `outercontent` can be used.

> LayoutTests/scrollingcoordinator/ios/scroll-position-after-reattach.html:36
> +    await new Promise(requestAnimationFrame);

Since this test is already pulling in `UIHelper`, you can use `UIHelper.animationFrame()`.
Comment 4 Antti Koivisto 2020-06-09 05:42:15 PDT
Comment on attachment 401434 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401434&action=review

>> LayoutTests/scrollingcoordinator/ios/scroll-position-after-reattach.html:33
>>      outercontent.remove();
> 
> While you're modifying this test, you can remove the `removed` variable which is useless, `outercontent` can be used.

You'd think so but 'outercontent' is not a variable. It is an implicit property on window object.
Comment 5 EWS 2020-06-09 05:57:27 PDT
Committed r262789: <https://trac.webkit.org/changeset/262789>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401434 [details].