Bug 212947 – [Win] ComplexTextControllerUniscribe: Retry ScriptShape with SCRIPT_UNDEFINED if it failed as USP_E_SCRIPT_NOT_IN_FONT

• Status: RESOLVED
• Resolution: FIXED
• Component: Text

[Fujii Hironori]

[Win] ComplexTextControllerUniscribe: Retry ScriptShape with SCRIPT_UNDEFINED if it failed as USP_E_SCRIPT_NOT_IN_FONT

Displaying Text with Uniscribe
https://docs.microsoft.com/en-us/windows/win32/intl/displaying-text-with-uniscribe

> 7. If ScriptShape returns the code USP_E_SCRIPT_NOT_IN_FONT or
> S_OK with the output containing missing glyphs, select characters
> from a different font. Either substitute another font or disable
> shaping by setting the eScript member of the SCRIPT_ANALYSIS
> structure passed to ScriptShape to SCRIPT_UNDEFINED. For more
> information, see Using Font Fallback.

[Fujii Hironori]

Created attachment 401410 [details]
Patch

[Fujii Hironori]

It's easy to test this issue by opening a Tibetan page at the
moment because there is another bug in fallback font selection
for Tibetan characters (Bug 212688). However, if the bug is
fixed, I don't know how can this issue be tested.

[Fujii Hironori]

Comment on attachment 401410 [details]
Patch

Clearing flags on attachment: 401410

Committed r262804: <https://trac.webkit.org/changeset/262804>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/64175943>

[Radar WebKit Bug Importer]

<rdar://problem/64175945>