WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
212943
[Intl] Update tests to support ICU 67
https://bugs.webkit.org/show_bug.cgi?id=212943
Summary
[Intl] Update tests to support ICU 67
Ross Kirsling
Reported
2020-06-08 17:56:55 PDT
[Intl] Update tests to support ICU 67
Attachments
Patch
(13.19 KB, patch)
2020-06-08 17:59 PDT
,
Ross Kirsling
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ross Kirsling
Comment 1
2020-06-08 17:59:40 PDT
Created
attachment 401403
[details]
Patch
Ross Kirsling
Comment 2
2020-06-08 18:07:09 PDT
Comment on
attachment 401403
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=401403&action=review
> JSTests/stress/intl-collator.js:106 > // Ignores irrelevant extension keys. > -shouldBe(testCollator(Intl.Collator('en-u-aa-aaaa-kn-true-bb-bbbb-co-eor-cc-cccc-y-yyd'), [{locale: 'en-u-co-eor-kn-true', collation: 'eor', numeric: true}, {locale: 'en-u-kn-true', numeric: true}]), true); > +shouldBe(testCollator(Intl.Collator('en-u-aa-aaaa-kf-upper-bb-bbbb-co-eor-cc-cccc-y-yyd'), [{locale: 'en-u-co-eor-kf-upper', collation: 'eor', caseFirst: 'upper'}, {locale: 'en-u-kf-upper', caseFirst: 'upper'}]), true); > > // Ignores other extensions. > -shouldBe(testCollator(Intl.Collator('en-u-kn-true-a-aa'), [{locale: 'en-u-kn-true', numeric: true}]), true); > -shouldBe(testCollator(Intl.Collator('en-a-aa-u-kn-true'), [{locale: 'en-u-kn-true', numeric: true}]), true); > -shouldBe(testCollator(Intl.Collator('en-a-aa-u-kn-true-b-bb'), [{locale: 'en-u-kn-true', numeric: true}]), true); > +shouldBe(testCollator(Intl.Collator('en-u-kf-upper-a-aa'), [{locale: 'en-u-kf-upper', caseFirst: 'upper'}]), true); > +shouldBe(testCollator(Intl.Collator('en-a-aa-u-kf-upper'), [{locale: 'en-u-kf-upper', caseFirst: 'upper'}]), true); > +shouldBe(testCollator(Intl.Collator('en-a-aa-u-kf-upper-b-bb'), [{locale: 'en-u-kf-upper', caseFirst: 'upper'}]), true);
FWIW: I switched these particular cases to be version-independent instead, but could've gone either way.
EWS
Comment 3
2020-06-08 19:19:23 PDT
Committed
r262763
: <
https://trac.webkit.org/changeset/262763
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 401403
[details]
.
Radar WebKit Bug Importer
Comment 4
2020-06-08 19:20:16 PDT
<
rdar://problem/64145730
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug