Bug 212940 - REGRESSION: [Safari Mojave for High Sierra] Accessing some of the featured pages on apple.com causes the webpage to crash
Summary: REGRESSION: [Safari Mojave for High Sierra] Accessing some of the featured pa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-08 16:42 PDT by Dean Jackson
Modified: 2020-06-09 14:20 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.73 KB, patch)
2020-06-08 16:49 PDT, Dean Jackson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2020-06-08 16:42:20 PDT 
Seeing crashes on apple.com when using high-performance WebGL.
Comment 1 Dean Jackson 2020-06-08 16:43:02 PDT 
rdar://63839405
Comment 2 Dean Jackson 2020-06-08 16:49:31 PDT 
Created attachment 401399 [details]
Patch

Note: This patch is for the safari-609-branch, so won't apply cleanly here.
Comment 3 Tim Horton 2020-06-08 16:52:02 PDT 
Comment on attachment 401399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401399&action=review

> Source/WebCore/platform/graphics/mac/SwitchingGPUClient.h:35
> +    static bool hasSingleton() { return !!m_singleton; }

The alternative is "singletonIfExists()" or whatever. I think we have a pattern for this.
Comment 4 Dean Jackson 2020-06-08 17:02:37 PDT 
Comment on attachment 401399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401399&action=review

>> Source/WebCore/platform/graphics/mac/SwitchingGPUClient.h:35
>> +    static bool hasSingleton() { return !!m_singleton; }
> 
> The alternative is "singletonIfExists()" or whatever. I think we have a pattern for this.

I'll do that on trunk. Thanks.
Comment 5 Dean Jackson 2020-06-09 01:51:01 PDT 
Committed r262783: <https://trac.webkit.org/changeset/262783>
Comment 6 Dean Jackson 2020-06-09 14:20:08 PDT 
Committed r262811: <https://trac.webkit.org/changeset/262811>