Bug 212940 – REGRESSION: [Safari Mojave for High Sierra] Accessing some of the featured pages on apple.com causes the webpage to crash

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Dean Jackson]

Seeing crashes on apple.com when using high-performance WebGL.

[Dean Jackson]

rdar://63839405

[Dean Jackson]

Created attachment 401399 [details]
Patch

Note: This patch is for the safari-609-branch, so won't apply cleanly here.

[Tim Horton]

Comment on attachment 401399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401399&action=review

> Source/WebCore/platform/graphics/mac/SwitchingGPUClient.h:35
> +    static bool hasSingleton() { return !!m_singleton; }

The alternative is "singletonIfExists()" or whatever. I think we have a pattern for this.

[Dean Jackson]

Comment on attachment 401399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401399&action=review

>> Source/WebCore/platform/graphics/mac/SwitchingGPUClient.h:35
>> +    static bool hasSingleton() { return !!m_singleton; }
> 
> The alternative is "singletonIfExists()" or whatever. I think we have a pattern for this.

I'll do that on trunk. Thanks.

[Dean Jackson]

Committed r262783: <https://trac.webkit.org/changeset/262783>

[Dean Jackson]

Committed r262811: <https://trac.webkit.org/changeset/262811>