Bug 212932 – WebKit.ShrinkToFit is failing on some bots

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

WebKit.ShrinkToFit is failing on some bots

[Tim Horton]

Created attachment 401389 [details]
Patch

[Tim Horton]

<rdar://problem/60972407>

[Simon Fraser (smfr)]

Comment on attachment 401389 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401389&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:66
> +        // This is 85 instead of 100 because we now have a scrollbar.

Does the "now" refer to "after this fix" or "now that the test has done something"? Remove it if the former.

[Tim Horton]

The latter. I will clarify the comment.

[Tim Horton]

Created attachment 401390 [details]
Patch

[Tim Horton]

Created attachment 401452 [details]
Patch

[EWS]

Committed r262800: <https://trac.webkit.org/changeset/262800>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401452 [details].

[Darin Adler]

Comment on attachment 401452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401452&action=review

> Tools/TestWebKitAPI/mac/mainMac.mm:43
> +    // CAUTION: Defaults set here are not automatically propagated to the
> +    // Web Content process. Those listed below are propagated manually.

I find this comment slightly mysterious. After reading the patch and the comments in the bug, I think we mean that WebKit *itself* happens to propagate all of these (maybe a pointer to the code that does it would help since this test tool *is* part of WebKit), but we could also be referring to some other part of TestWebKitAPI doing it.

[Tim Horton]

Comment on attachment 401452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401452&action=review

>> Tools/TestWebKitAPI/mac/mainMac.mm:43
>> +    // Web Content process. Those listed below are propagated manually.
> 
> I find this comment slightly mysterious. After reading the patch and the comments in the bug, I think we mean that WebKit *itself* happens to propagate all of these (maybe a pointer to the code that does it would help since this test tool *is* part of WebKit), but we could also be referring to some other part of TestWebKitAPI doing it.

I did mean WebKit, yes. Mostly trying to call out "if you add another default here it will not magically make it to the WP". Maybe it can be reworded.