Bug 212929 - Remove unnecessary variable in `WindowProxy::createJSWindowProxy`
Summary: Remove unnecessary variable in `WindowProxy::createJSWindowProxy`
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-08 15:42 PDT by Devin Rousso
Modified: 2020-06-08 16:23 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.32 KB, patch)
2020-06-08 15:43 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-06-08 15:42:39 PDT 
```
    Strong<JSWindowProxy> jsWindowProxy(vm, &JSWindowProxy::create(vm, *m_frame->window(), world));
    Strong<JSWindowProxy> jsWindowProxy2(jsWindowProxy);
```

Nothing seems to use `jsWindowProxy2`, so it should be removed (or have a comment as to why it's needed).

This was added in r78634 <https://webkit.org/b/54415> 🤯
Comment 1 Devin Rousso 2020-06-08 15:43:39 PDT 
Created attachment 401384 [details]
Patch
Comment 2 EWS 2020-06-08 16:23:00 PDT 
Committed r262751: <https://trac.webkit.org/changeset/262751>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401384 [details].
Comment 3 Radar WebKit Bug Importer 2020-06-08 16:23:21 PDT 
<rdar://problem/64139773>