Bug 212917 – Extended Color: Rename Color::lighten() and Color::darken() to Color::lightened() and Color::darkened()

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Extended Color: Rename Color::lighten() and Color::darken() to Color::lightened() and Color::darkened()

[Sam Weinig]

Created attachment 401365 [details]
Patch

[EWS]

Tools/Scripts/svn-apply failed to apply attachment 401365 [details] to trunk.
Please resolve the conflicts and upload a new patch.

[Sam Weinig]

Created attachment 401391 [details]
Patch

[EWS]

ChangeLog entry in Tools/ChangeLog contains OOPS!.

[Sam Weinig]

Created attachment 401393 [details]
Patch

[Darin Adler]

Comment on attachment 401393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401393&action=review

> Tools/TestWebKitAPI/Tests/WebCore/ColorTests.cpp:222
> +    auto cLigtened = Color(c).lightened().toSRGBASimpleColorLossy();

typo in existing code: "ligtened"

[Sam Weinig]

(In reply to Darin Adler from comment #6)
> Comment on attachment 401393 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401393&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebCore/ColorTests.cpp:222
> > +    auto cLigtened = Color(c).lightened().toSRGBASimpleColorLossy();
> 
> typo in existing code: "ligtened"

Gaaaaa :). I'll get it right one of these times.

[EWS]

Committed r262753: <https://trac.webkit.org/changeset/262753>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401393 [details].

[Radar WebKit Bug Importer]

<rdar://problem/64141679>