Bug 212910 - All platforms should enable CFPrefs read only mode in the WebContent process
Summary: All platforms should enable CFPrefs read only mode in the WebContent process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-08 12:33 PDT by Per Arne Vollan
Modified: 2020-06-09 12:58 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2020-06-08 12:34 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-06-08 12:33:00 PDT 
In https://bugs.webkit.org/show_bug.cgi?id=212411, CFPrefs read only mode was adopted, but not all platforms were included.
Comment 1 Per Arne Vollan 2020-06-08 12:34:32 PDT 
Created attachment 401358 [details]
Patch
Comment 2 Tim Horton 2020-06-08 12:37:55 PDT 
Comment on attachment 401358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401358&action=review

> Source/WTF/wtf/PlatformHave.h:646
> +    || ((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \

How certain are you that IPHONE_OS_VERSION is the right one to check in macCatalyst? (I think it's not, but I am not 100%)
Comment 3 Tim Horton 2020-06-08 18:26:02 PDT 
(In reply to Tim Horton from comment #2)
> Comment on attachment 401358 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401358&action=review
> 
> > Source/WTF/wtf/PlatformHave.h:646
> > +    || ((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \
> 
> How certain are you that IPHONE_OS_VERSION is the right one to check in
> macCatalyst? (I think it's not, but I am not 100%)

It is! Disregard me.
Comment 4 Per Arne Vollan 2020-06-09 12:33:10 PDT 
Comment on attachment 401358 [details]
Patch

Thanks for reviewing!
Comment 5 EWS 2020-06-09 12:57:21 PDT 
Committed r262805: <https://trac.webkit.org/changeset/262805>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401358 [details].
Comment 6 Radar WebKit Bug Importer 2020-06-09 12:58:15 PDT 
<rdar://problem/64176093>