RESOLVED FIXED 212910
All platforms should enable CFPrefs read only mode in the WebContent process
https://bugs.webkit.org/show_bug.cgi?id=212910
Summary All platforms should enable CFPrefs read only mode in the WebContent process
Per Arne Vollan
Reported 2020-06-08 12:33:00 PDT
In https://bugs.webkit.org/show_bug.cgi?id=212411, CFPrefs read only mode was adopted, but not all platforms were included.
Attachments
Patch (1.36 KB, patch)
2020-06-08 12:34 PDT, Per Arne Vollan
no flags
Per Arne Vollan
Comment 1 2020-06-08 12:34:32 PDT
Tim Horton
Comment 2 2020-06-08 12:37:55 PDT
Comment on attachment 401358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401358&action=review > Source/WTF/wtf/PlatformHave.h:646 > + || ((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \ How certain are you that IPHONE_OS_VERSION is the right one to check in macCatalyst? (I think it's not, but I am not 100%)
Tim Horton
Comment 3 2020-06-08 18:26:02 PDT
(In reply to Tim Horton from comment #2) > Comment on attachment 401358 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401358&action=review > > > Source/WTF/wtf/PlatformHave.h:646 > > + || ((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \ > > How certain are you that IPHONE_OS_VERSION is the right one to check in > macCatalyst? (I think it's not, but I am not 100%) It is! Disregard me.
Per Arne Vollan
Comment 4 2020-06-09 12:33:10 PDT
Comment on attachment 401358 [details] Patch Thanks for reviewing!
EWS
Comment 5 2020-06-09 12:57:21 PDT
Committed r262805: <https://trac.webkit.org/changeset/262805> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401358 [details].
Radar WebKit Bug Importer
Comment 6 2020-06-09 12:58:15 PDT
Note You need to log in before you can comment on or make changes to this bug.