Bug 212880 - Simplify fallback content handling in FrameLoader
Summary: Simplify fallback content handling in FrameLoader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-07 07:17 PDT by Rob Buis
Modified: 2020-06-08 02:05 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.47 KB, patch)
2020-06-07 07:18 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (6.49 KB, patch)
2020-06-08 01:21 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-06-07 07:17:29 PDT 
Simplify fallback content handling in FrameLoader, this can be inlined
and some HTMLObjectElement checks can be combined.
Comment 1 Rob Buis 2020-06-07 07:18:40 PDT 
Created attachment 401293 [details]
Patch
Comment 2 youenn fablet 2020-06-08 00:50:57 PDT 
Comment on attachment 401293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401293&action=review

> Source/WebCore/loader/DocumentLoader.cpp:1011
> +            HTMLFrameOwnerElement* owner = m_frame->ownerElement();

auto*
Comment 3 Rob Buis 2020-06-08 01:21:57 PDT 
Created attachment 401316 [details]
Patch
Comment 4 EWS 2020-06-08 02:04:38 PDT 
Committed r262704: <https://trac.webkit.org/changeset/262704>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401316 [details].
Comment 5 Radar WebKit Bug Importer 2020-06-08 02:05:19 PDT 
<rdar://problem/64111590>
Comment 6 Radar WebKit Bug Importer 2020-06-08 02:05:23 PDT 
<rdar://problem/64111592>