RESOLVED FIXED 212876
[LFC][BFC] Intrinsic width computation should take min/max-width into account. 
https://bugs.webkit.org/show_bug.cgi?id=212876
Summary [LFC][BFC] Intrinsic width computation should take min/max-width into account.
zalan
Reported 2020-06-06 20:50:03 PDT
ssia
Attachments
Patch (7.05 KB, patch)
2020-06-06 20:55 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (7.04 KB, patch)
2020-06-07 07:10 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2020-06-06 20:55:16 PDT
Created attachment 401285 [details] Patch
Antti Koivisto
Comment 2 2020-06-07 02:45:37 PDT
Comment on attachment 401285 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401285&action=review > Source/WebCore/layout/FormattingContextGeometry.cpp:120 > - return width; > + return style.logicalWidth(); Probably don't need this return since all paths of the switch return.
Antti Koivisto
Comment 3 2020-06-07 02:48:53 PDT
Comment on attachment 401285 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401285&action=review >> Source/WebCore/layout/FormattingContextGeometry.cpp:120 >> + return style.logicalWidth(); > > Probably don't need this return since all paths of the switch return. Actually, it is better to not have a default in the switch and instead have ASSERT_NOT_REACHED() here. That way if the enum ever gain another member the compiler will force handling that case.
zalan
Comment 4 2020-06-07 07:10:16 PDT
Created attachment 401291 [details] Patch
EWS
Comment 5 2020-06-07 08:00:12 PDT
Committed r262698: <https://trac.webkit.org/changeset/262698> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401291 [details].
Radar WebKit Bug Importer
Comment 6 2020-06-07 08:01:18 PDT
<rdar://problem/64089714>
Note You need to log in before you can comment on or make changes to this bug.