Bug 212872 - Extended Color: Replace uses of differenceSquared() with luminance based computations
Summary: Extended Color: Replace uses of differenceSquared() with luminance based comp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-06 18:34 PDT by Sam Weinig
Modified: 2020-06-08 11:39 PDT (History)
10 users (show)

See Also:

Attachments
Patch (10.45 KB, patch)
2020-06-06 18:35 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (10.44 KB, patch)
2020-06-07 07:54 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (10.69 KB, patch)
2020-06-07 10:18 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (10.74 KB, patch)
2020-06-07 11:00 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (15.33 KB, patch)
2020-06-07 13:21 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (15.23 KB, patch)
2020-06-07 17:54 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-06-06 18:34:20 PDT 
[Color] Replace uses of differenceSquared() with luminance based computations
Comment 1 Sam Weinig 2020-06-06 18:35:14 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-06-07 07:54:15 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-06-07 10:18:46 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-06-07 11:00:04 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2020-06-07 13:21:01 PDT Comment hidden (obsolete)
Comment 6 Sam Weinig 2020-06-07 17:54:32 PDT 
Created attachment 401307 [details]
Patch
Comment 7 Darin Adler 2020-06-08 11:23:24 PDT 
Comment on attachment 401307 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401307&action=review

> Source/WebCore/platform/graphics/Color.h:139
> +    WEBCORE_EXPORT Color lighten() const;
> +    WEBCORE_EXPORT Color darken() const;

A Cocoa-style name would be lightened/darkened or lightened/darkenedColor.
Comment 8 EWS 2020-06-08 11:38:37 PDT 
Committed r262729: <https://trac.webkit.org/changeset/262729>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401307 [details].
Comment 9 Radar WebKit Bug Importer 2020-06-08 11:39:20 PDT 
<rdar://problem/64128197>