Bug 212859 - Web Inspector: unify the naming scheme for agents used by instrumentation
Summary: Web Inspector: unify the naming scheme for agents used by instrumentation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-05 18:18 PDT by Devin Rousso
Modified: 2020-06-06 05:48 PDT (History)
11 users (show)

See Also:


Attachments
Patch (151.71 KB, patch)
2020-06-05 18:37 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (152.69 KB, patch)
2020-06-05 21:24 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-06-05 18:18:26 PDT
Here's what I think we should do (and have been doing a little bit already):
 - "persistent" agents are set when Web Inspector is connected
 - "enabled" agents are set when that agent is `enable`d, such as if the corresponding tab is visible
 - "tracking" agents are set when that agent is part of a timeline recording.
Comment 1 Devin Rousso 2020-06-05 18:37:00 PDT
Created attachment 401221 [details]
Patch
Comment 2 Devin Rousso 2020-06-05 21:24:45 PDT
Created attachment 401232 [details]
Patch
Comment 3 EWS 2020-06-06 05:47:59 PDT
Committed r262673: <https://trac.webkit.org/changeset/262673>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401232 [details].
Comment 4 Radar WebKit Bug Importer 2020-06-06 05:48:16 PDT
<rdar://problem/64067246>