WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
212859
Web Inspector: unify the naming scheme for agents used by instrumentation
https://bugs.webkit.org/show_bug.cgi?id=212859
Summary
Web Inspector: unify the naming scheme for agents used by instrumentation
Devin Rousso
Reported
2020-06-05 18:18:26 PDT
Here's what I think we should do (and have been doing a little bit already): - "persistent" agents are set when Web Inspector is connected - "enabled" agents are set when that agent is `enable`d, such as if the corresponding tab is visible - "tracking" agents are set when that agent is part of a timeline recording.
Attachments
Patch
(151.71 KB, patch)
2020-06-05 18:37 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Patch
(152.69 KB, patch)
2020-06-05 21:24 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Devin Rousso
Comment 1
2020-06-05 18:37:00 PDT
Created
attachment 401221
[details]
Patch
Devin Rousso
Comment 2
2020-06-05 21:24:45 PDT
Created
attachment 401232
[details]
Patch
EWS
Comment 3
2020-06-06 05:47:59 PDT
Committed
r262673
: <
https://trac.webkit.org/changeset/262673
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 401232
[details]
.
Radar WebKit Bug Importer
Comment 4
2020-06-06 05:48:16 PDT
<
rdar://problem/64067246
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug