Bug 212852 - Web Inspector: allow multiple resources for a given URL
Summary: Web Inspector: allow multiple resources for a given URL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-05 15:35 PDT by Devin Rousso
Modified: 2020-06-09 13:45 PDT (History)
4 users (show)

See Also:

Attachments
Patch (28.00 KB, patch)
2020-06-05 15:47 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (28.18 KB, patch)
2020-06-05 19:54 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-06-05 15:35:36 PDT 
Rather than use a `Map`, we should use a `Multimap`.
Comment 1 Devin Rousso 2020-06-05 15:47:44 PDT 
Created attachment 401209 [details]
Patch
Comment 2 Devin Rousso 2020-06-05 19:54:58 PDT 
Created attachment 401226 [details]
Patch

fix mistake in `WI.Frame.prototype.resourcesForURL` where the `WI.Frame` was added to the returned `Set` instead of the `WI.Frame.prototype.get mainResource`
Comment 3 BJ Burg 2020-06-09 13:20:18 PDT 
Comment on attachment 401226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401226&action=review

r=me

> Source/WebInspectorUI/UserInterface/Controllers/NetworkManager.js:472
> +            resources.addAll(this._mainFrame.resourcesForURL(url, recursivelySearchChildFrames));

NIce.
Comment 4 EWS 2020-06-09 13:44:18 PDT 
Committed r262806: <https://trac.webkit.org/changeset/262806>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401226 [details].
Comment 5 Radar WebKit Bug Importer 2020-06-09 13:45:20 PDT 
<rdar://problem/64178078>