Bug 212849 - AX: aria-modal nodes wrapped in aria-hidden are not honored
Summary: AX: aria-modal nodes wrapped in aria-hidden are not honored
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-05 15:14 PDT by chris fleizach
Modified: 2020-06-29 11:54 PDT (History)
9 users (show)

See Also:


Attachments
problem (962 bytes, text/html)
2020-06-05 15:14 PDT, chris fleizach
no flags Details
patch (26.42 KB, patch)
2020-06-18 11:44 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
patch (26.15 KB, patch)
2020-06-18 11:45 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
patch (25.76 KB, patch)
2020-06-18 11:48 PDT, chris fleizach
no flags Details | Formatted Diff | Diff
patch (25.83 KB, patch)
2020-06-18 13:32 PDT, chris fleizach
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2020-06-05 15:14:57 PDT
Created attachment 401207 [details]
problem

We determined that the div[role=“dialog”, aria-modal=“true”] in question is wrapped by div[aria-hidden=“true”]. Bc of this wrapper, the div[role=“dialog”, aria-modal=“true”] should be ignored.
Comment 1 Radar WebKit Bug Importer 2020-06-05 15:15:08 PDT
<rdar://problem/64047019>
Comment 2 chris fleizach 2020-06-05 15:15:15 PDT
<rdar://problem/63985730>
Comment 3 chris fleizach 2020-06-18 11:44:19 PDT
Created attachment 402217 [details]
patch
Comment 4 chris fleizach 2020-06-18 11:45:00 PDT
Created attachment 402218 [details]
patch
Comment 5 chris fleizach 2020-06-18 11:48:44 PDT
Created attachment 402219 [details]
patch
Comment 6 chris fleizach 2020-06-18 13:32:53 PDT
Created attachment 402233 [details]
patch
Comment 7 EWS 2020-06-29 11:54:24 PDT
Committed r263673: <https://trac.webkit.org/changeset/263673>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402233 [details].