Bug 212830 - -_focusTextInputContext should reposition the caret if called for an already focused text input context
Summary: -_focusTextInputContext should reposition the caret if called for an already ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-05 09:50 PDT by Daniel Bates
Modified: 2020-06-27 15:59 PDT (History)
2 users (show)

See Also:

Attachments
Patch (11.69 KB, patch)
2020-06-05 10:17 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
To land (12.04 KB, patch)
2020-06-05 10:30 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-06-05 09:50:45 PDT 
Update the code based on new feedback. -_focusTextInputContext should reposition the caret if called for an already focused text input context.
Comment 1 Radar WebKit Bug Importer 2020-06-05 09:50:59 PDT 
<rdar://problem/64032956>
Comment 2 Daniel Bates 2020-06-05 10:17:27 PDT 
Created attachment 401169 [details]
Patch
Comment 3 Wenson Hsieh 2020-06-05 10:21:18 PDT 
Comment on attachment 401169 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401169&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4297
> +    _pointInsideLastFocusedTextInputContext = WTF::nullopt;

Should we also reset this in `-cleanUpInteraction`?
Comment 4 Daniel Bates 2020-06-05 10:27:35 PDT 
Comment on attachment 401169 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401169&action=review

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4297
>> +    _pointInsideLastFocusedTextInputContext = WTF::nullopt;
> 
> Should we also reset this in `-cleanUpInteraction`?

Yes, of course
Comment 5 Daniel Bates 2020-06-05 10:27:47 PDT 
Comment on attachment 401169 [details]
Patch

Thanks for the review!
Comment 6 Daniel Bates 2020-06-05 10:30:43 PDT 
Created attachment 401170 [details]
To land
Comment 7 Daniel Bates 2020-06-05 14:29:11 PDT 
Comment on attachment 401170 [details]
To land

Clearing flags on attachment: 401170

Committed r262654: <https://trac.webkit.org/changeset/262654>
Comment 8 Daniel Bates 2020-06-05 14:29:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Daniel Bates 2020-06-27 15:50:16 PDT 
(In reply to Daniel Bates from comment #7)
> Comment on attachment 401170 [details]
> To land
> 
> Clearing flags on attachment: 401170
> 
> Committed r262654: <https://trac.webkit.org/changeset/262654>


This was wrong and caused <rdar://problem/64664156>. Reverting...
Comment 10 Daniel Bates 2020-06-27 15:59:53 PDT 
(In reply to Daniel Bates from comment #9)
> (In reply to Daniel Bates from comment #7)
> > Comment on attachment 401170 [details]
> > To land
> > 
> > Clearing flags on attachment: 401170
> > 
> > Committed r262654: <https://trac.webkit.org/changeset/262654>
> 
> 
> This was wrong and caused <rdar://problem/64664156>. Reverting...

Reverted in <https://trac.webkit.org/changeset/263630>