Bug 212823 – Unused parameter warnings in EventRegion.cpp and RenderLayerBacking.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Michael Catanzaro]

[1339/1877] Building CXX object Source/WebCore/CMakeFiles...es/WebCore/unified-sources/UnifiedSource-043dd90b-2.cpp.o
In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-2.cpp:3:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/rendering/EventRegion.cpp: In member function ‘void WebCore::EventRegion::unite(const WebCore::Region&, const WebCore::RenderStyle&, bool)’:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/rendering/EventRegion.cpp:120:66: warning: unused parameter ‘style’ [-Wunused-parameter]
  120 | void EventRegion::unite(const Region& region, const RenderStyle& style, bool overrideUserModifyIsEditable)
      |                                               ~~~~~~~~~~~~~~~~~~~^~~~~
[1392/1877] Building CXX object Source/WebCore/CMakeFiles...es/WebCore/unified-sources/UnifiedSource-043dd90b-9.cpp.o
In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-9.cpp:2:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/rendering/RenderLayerBacking.cpp: In member function ‘void WebCore::RenderLayerBacking::paintDebugOverlays(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&)’:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/rendering/RenderLayerBacking.cpp:3203:10: warning: unused variable ‘visibleDebugOverlayRegions’ [-Wunused-variable]
 3203 |     auto visibleDebugOverlayRegions = renderer().settings().visibleDebugOverlayRegions();
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/Source/WebCore/rendering/RenderLayerBacking.cpp: At global scope:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/rendering/RenderLayerBacking.cpp:3094:24: warning: ‘WTF::RefPtr<WebCore::Pattern> WebCore::patternForDescription(WebCore::PatternDescription, WebCore::FloatSize, WebCore::GraphicsContext&)’ defined but not used [-Wunused-function]
 3094 | static RefPtr<Pattern> patternForDescription(PatternDescription description, FloatSize contentOffset, GraphicsContext& destContext)
      |                        ^~~~~~~~~~~~~~~~~~~~~

[Michael Catanzaro]

Created attachment 401156 [details]
Patch for landing

[EWS]

Committed r262623: <https://trac.webkit.org/changeset/262623>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401156 [details].

[Radar WebKit Bug Importer]

<rdar://problem/64031883>

[Radar WebKit Bug Importer]

<rdar://problem/64031882>