Bug 212801 - URLs clicked on from -[WKWebView _showSafeBrowsingWarningWithURL:title:warning:details:completionHandler:] are ignored
Summary: URLs clicked on from -[WKWebView _showSafeBrowsingWarningWithURL:title:warnin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: All macOS 10.15
: P1 Critical
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-04 23:29 PDT by Richard Houle
Modified: 2020-06-08 12:10 PDT (History)
3 users (show)

See Also:

Attachments
Proposed fix (3.65 KB, patch)
2020-06-04 23:29 PDT, Richard Houle 		no flags Details | Formatted Diff | Diff
Proposed fix V2 (4.65 KB, patch)
2020-06-08 11:13 PDT, Richard Houle 		no flags Details | Formatted Diff | Diff
Proposed fix V3 (5.74 KB, patch)
2020-06-08 11:30 PDT, Richard Houle 		no flags Details | Formatted Diff | Diff
Proposed fix V4 (7.00 KB, patch)
2020-06-08 11:36 PDT, Richard Houle 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Houle 2020-06-04 23:29:35 PDT 
Created attachment 401122 [details]
Proposed fix

For more information about the Safari specific issue, please read <rdar://problem/63027631>.
Comment 1 Alexey Proskuryakov 2020-06-07 13:48:42 PDT 
Comment on attachment 401122 [details]
Proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=401122&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-2155
> -- (void)_showSafeBrowsingWarningWithTitle:(NSString *)title warning:(NSString *)warning details:(NSAttributedString *)details completionHandler:(void(^)(BOOL))completionHandler

This changes and removes SPI, will it break using ToT WebKit with shipping Safari?
Comment 2 Richard Houle 2020-06-07 14:51:29 PDT 
It will.

I will submit a modified patch that keeps compatibility with shipping Safari.
Comment 3 Richard Houle 2020-06-08 11:13:32 PDT 
Created attachment 401350 [details]
Proposed fix V2
Comment 4 Alex Christensen 2020-06-08 11:18:21 PDT 
Comment on attachment 401350 [details]
Proposed fix V2

You should use WK_MAC_TBA and WK_IOS_TBA in the WK_API_AVAILABLE macros.
You should also add a ChangeLog entry with the change.
Comment 5 Richard Houle 2020-06-08 11:30:17 PDT 
Created attachment 401351 [details]
Proposed fix V3
Comment 6 Alex Christensen 2020-06-08 11:31:06 PDT 
You need to change the file Source/WebKit/ChangeLog
Comment 7 Richard Houle 2020-06-08 11:36:50 PDT 
Created attachment 401352 [details]
Proposed fix V4
Comment 8 EWS 2020-06-08 12:09:47 PDT 
Committed r262732: <https://trac.webkit.org/changeset/262732>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401352 [details].
Comment 9 Radar WebKit Bug Importer 2020-06-08 12:10:21 PDT 
<rdar://problem/64129665>