Bug 212797 - [WPE] Behave like GDK_CURRENT_TIME when the timestamp is zero
Summary: [WPE] Behave like GDK_CURRENT_TIME when the timestamp is zero
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-04 21:03 PDT by Lauro Moura
Modified: 2020-06-07 17:16 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.53 KB, patch)
2020-06-04 21:06 PDT, Lauro Moura
cgarcia: review+
cgarcia: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2020-06-04 21:03:15 PDT
When the timestamp is zero, use WallTime::now() as the event time. Zero timestamps can happen in the WebDriver tests.

Follow up to bug212338.
Comment 1 Lauro Moura 2020-06-04 21:06:53 PDT
Created attachment 401115 [details]
Patch
Comment 2 Adrian Perez 2020-06-05 14:41:15 PDT
Comment on attachment 401115 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401115&action=review

> Source/WebKit/Shared/libwpe/WebEventFactory.cpp:68
> +        return WallTime::now();

I *think* that this is right, but I would prefer that Carlos García confirms =)
Comment 3 Carlos Garcia Campos 2020-06-06 05:12:13 PDT
Comment on attachment 401115 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401115&action=review

> Source/WebKit/Shared/libwpe/WebEventFactory.cpp:66
> +    // Behave like GDK_CURRENT_TIME

I would remove this comment, it might be confusing. Or I would say something like 0 means current time.
Comment 4 Lauro Moura 2020-06-07 17:16:45 PDT
Committed r262702: <https://trac.webkit.org/changeset/262702>