Bug 212793 - [JSC] Report extra memory allocation from PropertyTable
Summary: [JSC] Report extra memory allocation from PropertyTable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-04 17:21 PDT by Yusuke Suzuki
Modified: 2020-06-05 09:58 PDT (History)
7 users (show)

See Also:

Attachments
Patch (9.10 KB, patch)
2020-06-04 17:22 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-06-04 17:21:21 PDT 
[JSC] Report extra memory allocation from PropertyTable
Comment 1 Yusuke Suzuki 2020-06-04 17:22:20 PDT 
Created attachment 401100 [details]
Patch
Comment 2 Yusuke Suzuki 2020-06-04 18:22:50 PDT 
Comment on attachment 401100 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401100&action=review

> Source/JavaScriptCore/runtime/PropertyMapHashTable.h:531
> +    vm.heap.reportExtraMemoryAllocated(dataSize());

Maybe, we should report

if (oldDataSize < dataSize())
    vm.heap.reportExtraMemoryAllocated(dataSize() - oldDataSize);

changed.
Comment 3 Yusuke Suzuki 2020-06-04 22:55:27 PDT 
Ran jsc tests locally.
Comment 4 Yusuke Suzuki 2020-06-04 22:59:02 PDT 
Committed r262600: <https://trac.webkit.org/changeset/262600>
Comment 5 Radar WebKit Bug Importer 2020-06-05 09:58:15 PDT 
<rdar://problem/64033289>