Disable CFNetwork AppSSO interception for Mac Catalyst.
<rdar://problem/63738783>
Created attachment 401082 [details] Patch
The current patch only disable CFNetwork interception per network session. Let me use the global switch to do it for other processes.
Created attachment 401083 [details] Patch
Comment on attachment 401082 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401082&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 > +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only.
Comment on attachment 401083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401083&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 > +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only.
Comment on attachment 401083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401083&action=review Thanks Chris for the r+. >> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 >> +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) > > What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only. The AppSSO framework is only available for iOS, macOS and Catalyst. So we are good for the other two platforms.
Comment on attachment 401083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401083&action=review >>> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 >>> +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) >> >> What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only. > > The AppSSO framework is only available for iOS, macOS and Catalyst. So we are good for the other two platforms. Is the NSURLSessionConfiguration property available on all platforms? It might be nice to just remove this ifdef for future-proofing 🤷♂️
(In reply to Tim Horton from comment #8) > Comment on attachment 401083 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401083&action=review > > >>> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 > >>> +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) > >> > >> What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only. > > > > The AppSSO framework is only available for iOS, macOS and Catalyst. So we are good for the other two platforms. > > Is the NSURLSessionConfiguration property available on all platforms? It > might be nice to just remove this ifdef for future-proofing 🤷♂️ Yes, it is available on all platform, merely a no-op on platform that don't support AppSSO.
Committed r262585: <https://trac.webkit.org/changeset/262585> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401083 [details].
(In reply to Chris Dumez from comment #9) > (In reply to Tim Horton from comment #8) > > Comment on attachment 401083 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=401083&action=review > > > > >>> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 > > >>> +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) > > >> > > >> What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only. > > > > > > The AppSSO framework is only available for iOS, macOS and Catalyst. So we are good for the other two platforms. > > > > Is the NSURLSessionConfiguration property available on all platforms? It > > might be nice to just remove this ifdef for future-proofing 🤷♂️ > > Yes, it is available on all platform, merely a no-op on platform that don't > support AppSSO. I think we need to support -2 macOS. Therefore, we can't do that now.