RESOLVED FIXED 212787
Disable CFNetwork AppSSO interception for Mac Catalyst 
https://bugs.webkit.org/show_bug.cgi?id=212787
Summary Disable CFNetwork AppSSO interception for Mac Catalyst
Jiewen Tan
Reported 2020-06-04 15:44:40 PDT
Disable CFNetwork AppSSO interception for Mac Catalyst.
Attachments
Patch (1.36 KB, patch)
2020-06-04 15:48 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (2.61 KB, patch)
2020-06-04 15:58 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2020-06-04 15:45:01 PDT
<rdar://problem/63738783>
Jiewen Tan
Comment 2 2020-06-04 15:48:28 PDT
Created attachment 401082 [details] Patch
Jiewen Tan
Comment 3 2020-06-04 15:51:48 PDT
The current patch only disable CFNetwork interception per network session. Let me use the global switch to do it for other processes.
Jiewen Tan
Comment 4 2020-06-04 15:58:13 PDT
Created attachment 401083 [details] Patch
Chris Dumez
Comment 5 2020-06-04 15:58:33 PDT
Comment on attachment 401082 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401082&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 > +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only.
Chris Dumez
Comment 6 2020-06-04 15:59:04 PDT
Comment on attachment 401083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401083&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 > +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only.
Jiewen Tan
Comment 7 2020-06-04 16:16:49 PDT
Comment on attachment 401083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401083&action=review Thanks Chris for the r+. >> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 >> +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) > > What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only. The AppSSO framework is only available for iOS, macOS and Catalyst. So we are good for the other two platforms.
Tim Horton
Comment 8 2020-06-04 16:39:02 PDT
Comment on attachment 401083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401083&action=review >>> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 >>> +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) >> >> What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only. > > The AppSSO framework is only available for iOS, macOS and Catalyst. So we are good for the other two platforms. Is the NSURLSessionConfiguration property available on all platforms? It might be nice to just remove this ifdef for future-proofing 🤷‍♂️
Chris Dumez
Comment 9 2020-06-04 16:39:54 PDT
(In reply to Tim Horton from comment #8) > Comment on attachment 401083 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401083&action=review > > >>> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 > >>> +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) > >> > >> What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only. > > > > The AppSSO framework is only available for iOS, macOS and Catalyst. So we are good for the other two platforms. > > Is the NSURLSessionConfiguration property available on all platforms? It > might be nice to just remove this ifdef for future-proofing 🤷‍♂️ Yes, it is available on all platform, merely a no-op on platform that don't support AppSSO.
EWS
Comment 10 2020-06-04 16:54:06 PDT
Committed r262585: <https://trac.webkit.org/changeset/262585> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401083 [details].
Jiewen Tan
Comment 11 2020-06-04 17:09:46 PDT
(In reply to Chris Dumez from comment #9) > (In reply to Tim Horton from comment #8) > > Comment on attachment 401083 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=401083&action=review > > > > >>> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 > > >>> +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) > > >> > > >> What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only. > > > > > > The AppSSO framework is only available for iOS, macOS and Catalyst. So we are good for the other two platforms. > > > > Is the NSURLSessionConfiguration property available on all platforms? It > > might be nice to just remove this ifdef for future-proofing 🤷‍♂️ > > Yes, it is available on all platform, merely a no-op on platform that don't > support AppSSO. I think we need to support -2 macOS. Therefore, we can't do that now.
Note You need to log in before you can comment on or make changes to this bug.