Bug 212764 - [EWS] Should be able to specify a subset of ports when posting patches to fix port builds
Summary: [EWS] Should be able to specify a subset of ports when posting patches to fix...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-04 11:10 PDT by David Kilzer (:ddkilzer)
Modified: 2020-06-05 10:52 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-06-04 11:10:49 PDT
Should be able to specify a subset of ports when posting patches to fix port builds.

It's a waste of resources to post patches just to find out if you've fixed all the compiler errors for a subset of ports.

It would be nice if there was a way to specify which port(s) a patch should be run on so EWS doesn't spend time building and running tests on patches meant to test build fixes.
Comment 1 Alexey Proskuryakov 2020-06-04 16:03:41 PDT
I'm skeptical about this. This would make it really difficult to tell if EWS was green. And I don't know how much EWS should trust engineer's opinion that they didn't break anything unexpectedly.
Comment 2 David Kilzer (:ddkilzer) 2020-06-05 10:52:12 PDT
(In reply to Alexey Proskuryakov from comment #1)
> I'm skeptical about this. This would make it really difficult to tell if EWS
> was green. And I don't know how much EWS should trust engineer's opinion
> that they didn't break anything unexpectedly.

We could use a different color for bubbles with skipped platforms.

This would not be used for the "final" patch for review; only for intermediate patches where an engineer is trying to make a patch compile for a port that they don't have access to build.

Obviously this requires some trust, but marking skipped platforms with a different color would make this pretty obvious.  Maybe commit-queue could refuse to commit a patch with skipped platforms, too.

Of course, maybe developers would be too lazy to use this anyway, so implementing it wouldn't be useful.  :)