Bug 212739 - File URLs with hostnames are misleading
Summary: File URLs with hostnames are misleading
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-04 05:03 PDT by youenn fablet
Modified: 2020-06-08 04:33 PDT (History)
14 users (show)

See Also:

Attachments
Patch (8.27 KB, patch)
2020-06-04 05:26 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (8.32 KB, patch)
2020-06-05 00:34 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Rebasing (141.04 KB, patch)
2020-06-08 00:34 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (8.40 KB, patch)
2020-06-08 00:40 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Rebasing (141.81 KB, patch)
2020-06-08 02:32 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (8.43 KB, patch)
2020-06-08 02:40 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-06-04 05:03:33 PDT 
File URLs with hostnames are misleading
Comment 1 youenn fablet 2020-06-04 05:03:46 PDT 
<rdar://problem/63754917>
Comment 2 youenn fablet 2020-06-04 05:26:06 PDT 
Created attachment 401015 [details]
Patch
Comment 3 youenn fablet 2020-06-05 00:34:30 PDT 
Created attachment 401127 [details]
Patch
Comment 4 Alex Christensen 2020-06-05 12:42:47 PDT 
Comment on attachment 401127 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401127&action=review

seems reasonable.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:337
> +        TestWebKitAPI::Util::sleep(0.1);

spinRunLoop might be nicer here.  It could save almost 1/10 of a second each time this test is run.
Comment 5 youenn fablet 2020-06-08 00:34:57 PDT 
Created attachment 401314 [details]
Rebasing
Comment 6 youenn fablet 2020-06-08 00:40:51 PDT 
Created attachment 401315 [details]
Patch for landing
Comment 7 youenn fablet 2020-06-08 02:32:21 PDT 
Created attachment 401318 [details]
Rebasing
Comment 8 youenn fablet 2020-06-08 02:40:23 PDT 
Created attachment 401319 [details]
Patch for landing
Comment 9 EWS 2020-06-08 04:33:20 PDT 
Committed r262707: <https://trac.webkit.org/changeset/262707>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401319 [details].