Bug 212716 - Inserted text placeholder should vertically align to top and behave like block-level element when it has 0 width
Summary: Inserted text placeholder should vertically align to top and behave like bloc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-03 14:49 PDT by Daniel Bates
Modified: 2020-06-03 17:02 PDT (History)
7 users (show)

See Also:

Attachments
Patch (9.80 KB, patch)
2020-06-03 15:04 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
To Land (9.81 KB, patch)
2020-06-03 17:01 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-06-03 14:49:58 PDT 
Update appearance of text placeholder based on feedback. Two changes

1. Vertically align top the placeholder
2. Placeholder should be on its own line when its width is 0: behave like a block-level element.
Comment 1 Daniel Bates 2020-06-03 14:50:18 PDT 
<rdar://problem/62672479>
Comment 2 Daniel Bates 2020-06-03 15:04:03 PDT 
Created attachment 400970 [details]
Patch
Comment 3 Daniel Bates 2020-06-03 15:06:27 PDT 
Comment on attachment 400970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400970&action=review

> Source/WebCore/ChangeLog:9
> +        Refine the appearance of text placeholder based on feedback:

of => of a
Comment 4 Daniel Bates 2020-06-03 15:26:49 PDT 
Thanks Darin!
Comment 5 Daniel Bates 2020-06-03 17:01:31 PDT 
Created attachment 400983 [details]
To Land
Comment 6 Daniel Bates 2020-06-03 17:02:02 PDT 
Committed r262525: <https://trac.webkit.org/changeset/262525>