Bug 212712 - ITP SQLite Database should only vacuum once per day
Summary: ITP SQLite Database should only vacuum once per day
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks: 214264
  Show dependency tree / graph
 
Reported: 2020-06-03 12:35 PDT by Kate Cheney
Modified: 2020-07-13 10:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.82 KB, patch)
2020-06-03 13:27 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
Patch (5.03 KB, patch)
2020-06-05 14:04 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2020-06-03 12:35:50 PDT 
Currently the SQLite Database runs a vacuum command each time statistics are processed. This is probably too frequent, because the database rarely needs to delete large amounts of data. We can cut this down to once a day.
Comment 1 Radar WebKit Bug Importer 2020-06-03 12:36:14 PDT 
<rdar://problem/63939711>
Comment 2 Kate Cheney 2020-06-03 13:27:25 PDT 
Created attachment 400964 [details]
Patch
Comment 3 Brent Fulgham 2020-06-03 20:02:41 PDT 
Comment on attachment 400964 [details]
Patch

Great! Let’s see how this looks...
Comment 4 EWS 2020-06-04 08:03:09 PDT 
Committed r262538: <https://trac.webkit.org/changeset/262538>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400964 [details].
Comment 5 Kate Cheney 2020-06-05 14:04:18 PDT 
Reopening to attach new patch.
Comment 6 Kate Cheney 2020-06-05 14:04:19 PDT 
Created attachment 401195 [details]
Patch
Comment 7 Brent Fulgham 2020-06-05 15:02:54 PDT 
Comment on attachment 401195 [details]
Patch

r=me
Comment 8 EWS 2020-06-05 15:12:12 PDT 
Committed r262659: <https://trac.webkit.org/changeset/262659>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401195 [details].