Bug 21270 - Avoid unnecessary copy of params for no-param functions that don't use "this"
Summary: Avoid unnecessary copy of params for no-param functions that don't use "this"
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-01 02:36 PDT by Maciej Stachowiak
Modified: 2012-09-06 23:42 PDT (History)
1 user (show)

See Also:


Attachments
first attempt - not clear if it has the desired perf benefit (22.64 KB, patch)
2008-10-01 02:38 PDT, Maciej Stachowiak
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2008-10-01 02:36:36 PDT
When a function that has no formal parameters, and which does not use "this", is called with too many arguments, it is not necessary to copy the arguments and build a second call frame. Avoiding this should lead to a speedup.
Comment 1 Maciej Stachowiak 2008-10-01 02:38:34 PDT
Created attachment 23973 [details]
first attempt - not clear if it has the desired perf benefit
Comment 2 Maciej Stachowiak 2008-10-01 12:31:52 PDT
Comment on attachment 23973 [details]
first attempt - not clear if it has the desired perf benefit

I did not mean to flag this for review.
Comment 3 Gavin Barraclough 2012-09-06 23:42:25 PDT
I think this case has been covered by revering the arguments – we now only need to fixup the arguments if too few are passed.