Bug 212676 - VMInspector APIs should be taking a VM* instead of a JSGlobalObject*.
Summary: VMInspector APIs should be taking a VM* instead of a JSGlobalObject*.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-02 17:55 PDT by Mark Lam
Modified: 2020-06-02 18:27 PDT (History)
6 users (show)

See Also:


Attachments
proposed patch. (10.88 KB, patch)
2020-06-02 18:00 PDT, Mark Lam
saam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-06-02 17:55:39 PDT
This because:
1. none of the functions currently taking a JSGlobalObject* actually need the globalObject.  All of them need the VM.
2. the role of the VMInspector is to enable inspection of the VM.  By requiring that it be passed a JSGlobalObject*, we were actually preventing the VMInspector from being used in code that have a VM to inspect but don't have a JSGlobalObject to use.
Comment 1 Mark Lam 2020-06-02 18:00:09 PDT
Created attachment 400871 [details]
proposed patch.
Comment 2 Mark Lam 2020-06-02 18:26:21 PDT
Thanks for the reviews.  Landed in r262467: <http://trac.webkit.org/r262467>.
Comment 3 Radar WebKit Bug Importer 2020-06-02 18:27:16 PDT
<rdar://problem/63902729>