Bug 212662 - AXIsolatedTree::updateNode should not call nodeForID.
Summary: AXIsolatedTree::updateNode should not call nodeForID.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-02 14:26 PDT by Andres Gonzalez
Modified: 2020-06-02 17:00 PDT (History)
9 users (show)

See Also:


Attachments
Patch (2.47 KB, patch)
2020-06-02 15:56 PDT, Andres Gonzalez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-06-02 14:26:45 PDT
AXIsolatedTree::updateNode should not call nodeForID.
Comment 1 Andres Gonzalez 2020-06-02 15:56:42 PDT
Created attachment 400862 [details]
Patch
Comment 2 chris fleizach 2020-06-02 16:00:22 PDT
Comment on attachment 400862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400862&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:-206
> -    if (auto object = nodeForID(axID)) {

do you want to add an assert in nodeForID about what thread its on?
Comment 3 EWS 2020-06-02 16:59:28 PDT
Committed r262463: <https://trac.webkit.org/changeset/262463>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400862 [details].
Comment 4 Radar WebKit Bug Importer 2020-06-02 17:00:20 PDT
<rdar://problem/63899599>