Bug 212646 - Crash with uncaught exception: *** -[AVSampleBufferAudioRenderer enqueueSampleBuffer:] Sample buffer has media type 'vide' instead of 'soun'
Summary: Crash with uncaught exception: *** -[AVSampleBufferAudioRenderer enqueueSampl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-02 10:50 PDT by Jer Noble
Modified: 2020-06-03 12:25 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.05 KB, patch)
2020-06-02 10:57 PDT, Jer Noble
eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (5.05 KB, patch)
2020-06-02 11:04 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-06-02 10:50:02 PDT
Crash with uncaught exception: *** -[AVSampleBufferAudioRenderer enqueueSampleBuffer:] Sample buffer has media type 'vide' instead of 'soun'
Comment 1 Jer Noble 2020-06-02 10:52:15 PDT
<rdar://problem/63040834>
Comment 2 Jer Noble 2020-06-02 10:57:17 PDT
Created attachment 400839 [details]
Patch
Comment 3 Eric Carlson 2020-06-02 10:59:50 PDT
Comment on attachment 400839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400839&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:1140
> +        // AVSampleBufferDisplayLayer will throw an un-documented exception is passed a sample

s/is/if/

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:1206
> +        // AVSampleBufferAudioRenderer will throw an un-documented exception is passed a sample

Ditto
Comment 4 Jer Noble 2020-06-02 11:04:20 PDT
Created attachment 400841 [details]
Patch for landing
Comment 5 Peng Liu 2020-06-02 11:07:35 PDT
Comment on attachment 400839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400839&action=review

> Source/WebCore/ChangeLog:9
> +        Protect against the possibility of AVStreamDataParser generating non-video or -audio saples in an otherwise

s/saples/samples?
Comment 6 Jer Noble 2020-06-03 12:25:56 PDT
Committed r262506: <https://trac.webkit.org/changeset/262506>