Bug 212628 - REGRESSION (r258949): Dynamic user accent color changes are not respected by WKWebView
Summary: REGRESSION (r258949): Dynamic user accent color changes are not respected by ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-02 00:39 PDT by Tim Horton
Modified: 2020-06-02 11:04 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.99 KB, patch)
2020-06-02 00:40 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (5.07 KB, patch)
2020-06-02 01:45 PDT, Tim Horton 		pvollan: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-06-02 00:39:26 PDT 
REGRESSION (r258949): Dynamic user accent color changes are not respected by WKWebView
Comment 1 Tim Horton 2020-06-02 00:40:03 PDT 
Created attachment 400790 [details]
Patch
Comment 2 Tim Horton 2020-06-02 00:40:05 PDT 
<rdar://problem/63436275>
Comment 3 Tim Horton 2020-06-02 01:45:46 PDT 
Created attachment 400796 [details]
Patch
Comment 4 Per Arne Vollan 2020-06-02 08:35:32 PDT 
Comment on attachment 400796 [details]
Patch

Thanks for fixing this! R=me.
Comment 5 Tim Horton 2020-06-02 10:09:52 PDT 
https://trac.webkit.org/changeset/262427/webkit
Comment 6 Darin Adler 2020-06-02 10:55:04 PDT 
Comment on attachment 400796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400796&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:926
> +static const WTF::String& userAccentColorPreferenceKey()
> +{
> +    static NeverDestroyed<WTF::String> userAccentColorPreferenceKey(MAKE_STATIC_STRING_IMPL("AppleAccentColor"));
> +    return userAccentColorPreferenceKey;
> +}

Possible future tidying step. Seems like this could return a const char* or an ASCIILiteral instead. No need for a NeverDestroyed, and comparing a WTF::String is not faster with another WTF::String than it is with a const char*.

Or this could be userAccentColorPreferenceKey() instead.
Comment 7 Tim Horton 2020-06-02 11:04:11 PDT 
(In reply to Darin Adler from comment #6)
> Comment on attachment 400796 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=400796&action=review
> 
> > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:926
> > +static const WTF::String& userAccentColorPreferenceKey()
> > +{
> > +    static NeverDestroyed<WTF::String> userAccentColorPreferenceKey(MAKE_STATIC_STRING_IMPL("AppleAccentColor"));
> > +    return userAccentColorPreferenceKey;
> > +}
> 
> Possible future tidying step. Seems like this could return a const char* or
> an ASCIILiteral instead. No need for a NeverDestroyed, and comparing a
> WTF::String is not faster with another WTF::String than it is with a const
> char*.
> 
> Or this could be userAccentColorPreferenceKey() instead.

Heh, I followed what we did with all of our generated preference keys. OK! This is good to know.