Bug 212620 - Add ENABLE(WHEEL_EVENT_REGIONS), enabled on macOS which is the only platform that needs wheel event regions for scrolling thread hit-testing
Summary: Add ENABLE(WHEEL_EVENT_REGIONS), enabled on macOS which is the only platform ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-01 16:54 PDT by Simon Fraser (smfr)
Modified: 2020-06-02 13:18 PDT (History)
14 users (show)

See Also:

Attachments
Patch (7.75 KB, patch)
2020-06-01 16:55 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-06-01 16:54:05 PDT 
Add ENABLE(WHEEL_EVENT_REGIONS), enabled on macOS which is the only platform that needs wheel event regions for scrolling thread hit-testing
Comment 1 Simon Fraser (smfr) 2020-06-01 16:55:49 PDT 
Created attachment 400769 [details]
Patch
Comment 2 Darin Adler 2020-06-01 17:36:52 PDT 
Comment on attachment 400769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400769&action=review

> Source/WTF/wtf/PlatformEnable.h:495
> +#if !defined(ENABLE_WHEEL_EVENT_REGIONS)
> +#define ENABLE_WHEEL_EVENT_REGIONS 0
> +#endif

We only need these for things that default to 1. I am planning on removing the items here that default to 0. The list is not complete, so it doesn’t document all the enable settings, and there is no effect if any particular one is removed.

I think you can just omit this entirely.
Comment 3 Simon Fraser (smfr) 2020-06-02 13:17:48 PDT 
https://trac.webkit.org/changeset/262437/webkit
Comment 4 Radar WebKit Bug Importer 2020-06-02 13:18:19 PDT 
<rdar://problem/63889023>