WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
212620
Add ENABLE(WHEEL_EVENT_REGIONS), enabled on macOS which is the only platform that needs wheel event regions for scrolling thread hit-testing
https://bugs.webkit.org/show_bug.cgi?id=212620
Summary
Add ENABLE(WHEEL_EVENT_REGIONS), enabled on macOS which is the only platform ...
Simon Fraser (smfr)
Reported
2020-06-01 16:54:05 PDT
Add ENABLE(WHEEL_EVENT_REGIONS), enabled on macOS which is the only platform that needs wheel event regions for scrolling thread hit-testing
Attachments
Patch
(7.75 KB, patch)
2020-06-01 16:55 PDT
,
Simon Fraser (smfr)
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2020-06-01 16:55:49 PDT
Created
attachment 400769
[details]
Patch
Darin Adler
Comment 2
2020-06-01 17:36:52 PDT
Comment on
attachment 400769
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=400769&action=review
> Source/WTF/wtf/PlatformEnable.h:495 > +#if !defined(ENABLE_WHEEL_EVENT_REGIONS) > +#define ENABLE_WHEEL_EVENT_REGIONS 0 > +#endif
We only need these for things that default to 1. I am planning on removing the items here that default to 0. The list is not complete, so it doesn’t document all the enable settings, and there is no effect if any particular one is removed. I think you can just omit this entirely.
Simon Fraser (smfr)
Comment 3
2020-06-02 13:17:48 PDT
https://trac.webkit.org/changeset/262437/webkit
Radar WebKit Bug Importer
Comment 4
2020-06-02 13:18:19 PDT
<
rdar://problem/63889023
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug