Bug 212619 – [iOS] WKProcessAssertionBackgroundTaskManager incorrectly ignores expiration notifications for daemons

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

WKProcessAssertionBackgroundTaskManager incorrectly ignores expiration notifications for daemons, because it rely on visibility to make decisions.

[Chris Dumez]

Created attachment 400770 [details]
Patch

[Chris Dumez]

Created attachment 400771 [details]
Patch

[Chris Dumez]

Created attachment 400825 [details]
Patch

[Chris Dumez]

Created attachment 400828 [details]
Patch

[Chris Dumez]

Created attachment 400830 [details]
Patch

[Alex Christensen]

Comment on attachment 400830 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400830&action=review

> Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:53
> +    return [[[RBSProcessHandle currentProcess] activeLimitations] runTime] != RBSProcessTimeLimitationNone;

It might be worth putting this inside a std::call_once, because this should never change, right?

> Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:241
> +    auto remainingTime = [[[RBSProcessHandle currentProcess] activeLimitations] runTime];

Can we use dot syntax for any of this?

[Chris Dumez]

Comment on attachment 400830 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400830&action=review

>> Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:53
>> +    return [[[RBSProcessHandle currentProcess] activeLimitations] runTime] != RBSProcessTimeLimitationNone;
> 
> It might be worth putting this inside a std::call_once, because this should never change, right?

It totally changes. For example, for applications, based on app visibility. The timer should only get started after the app gets backgrounded and thus this would return RBSProcessTimeLimitationNone when foreground and a positive value when background.

>> Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:241
>> +    auto remainingTime = [[[RBSProcessHandle currentProcess] activeLimitations] runTime];
> 
> Can we use dot syntax for any of this?

ok

[Chris Dumez]

Created attachment 400875 [details]
Patch

[EWS]

Committed r262477: <https://trac.webkit.org/changeset/262477>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400875 [details].

[Radar WebKit Bug Importer]

<rdar://problem/63909510>