Bug 212618 – Web Inspector: Graphics: should use the `id` (name) of the animation if it exists

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

```
    window.animation = document.body.animate([], {id: "OldName"});
```
should appear as "OldName" in Web Inspector, not "Animation 1"

[Devin Rousso]

Created attachment 400765 [details]
Patch

[Devin Rousso]

Created attachment 400766 [details]
[Image] after Patch is applied

[Timothy Hatcher]

Comment on attachment 400765 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400765&action=review

> Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js:162
> +        }

This formatting looks wrong, but what else could we do?

> Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js:168
> +            this._idRow.value = cssAnimationName === displayName ? null : displayName;

I’d almost flip this so null is last.

> Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js:172
> +            this._idRow.value = cssTransitionProperty === displayName ? null : displayName;

Ditto.

[Devin Rousso]

Comment on attachment 400765 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400765&action=review

>> Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js:162
>> +        }
> 
> This formatting looks wrong, but what else could we do?

oh, i actually don't need the braces here anymore :P

>> Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js:168
>> +            this._idRow.value = cssAnimationName === displayName ? null : displayName;
> 
> I’d almost flip this so null is last.

i wish there was a shorthand for `foo === bar ? bar : null` :(

[Devin Rousso]

Created attachment 400768 [details]
Patch

[EWS Watchlist]

This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.

[EWS]

Committed r262404: <https://trac.webkit.org/changeset/262404>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400768 [details].

[Radar WebKit Bug Importer]

<rdar://problem/63852510>