``` window.animation = document.body.animate([], {id: "OldName"}); ``` should appear as "OldName" in Web Inspector, not "Animation 1"
Created attachment 400765 [details] Patch
Created attachment 400766 [details] [Image] after Patch is applied
Comment on attachment 400765 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400765&action=review > Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js:162 > + } This formatting looks wrong, but what else could we do? > Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js:168 > + this._idRow.value = cssAnimationName === displayName ? null : displayName; I’d almost flip this so null is last. > Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js:172 > + this._idRow.value = cssTransitionProperty === displayName ? null : displayName; Ditto.
Comment on attachment 400765 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400765&action=review >> Source/WebInspectorUI/UserInterface/Views/AnimationContentView.js:162 >> + } > > This formatting looks wrong, but what else could we do? oh, i actually don't need the braces here anymore :P >> Source/WebInspectorUI/UserInterface/Views/AnimationDetailsSidebarPanel.js:168 >> + this._idRow.value = cssAnimationName === displayName ? null : displayName; > > I’d almost flip this so null is last. i wish there was a shorthand for `foo === bar ? bar : null` :(
Created attachment 400768 [details] Patch
This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.
Committed r262404: <https://trac.webkit.org/changeset/262404> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400768 [details].
<rdar://problem/63852510>