Bug 212612 - Revise PVRTC compressed texture validation in ANGLE backend for WebGL
Summary: Revise PVRTC compressed texture validation in ANGLE backend for WebGL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords: InRadar
Depends on: 212240
Blocks:
  Show dependency tree / graph
 
Reported: 2020-06-01 14:20 PDT by Kenneth Russell
Modified: 2020-06-02 16:26 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.62 KB, patch)
2020-06-01 14:23 PDT, Kenneth Russell 		no flags Details | Formatted Diff | Diff
Patch (8.73 KB, patch)
2020-06-01 19:39 PDT, Kenneth Russell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2020-06-01 14:20:56 PDT 
While upstreaming the fix for Bug 212240 into ANGLE in http://anglebug.com/4652 , some errors were discovered in the size validation for these compressed textures. To simplify identifying these fixes, the PVRTC validation in WebKit's copy of ANGLE should be updated with them separately.
Comment 1 Kenneth Russell 2020-06-01 14:23:41 PDT 
Created attachment 400759 [details]
Patch
Comment 2 Kenneth Russell 2020-06-01 14:24:09 PDT 
Note: holding off requesting commit queue until the upstream patch has been reviewed and landed in ANGLE.
Comment 3 EWS Watchlist 2020-06-01 14:24:31 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Kenneth Russell 2020-06-01 16:24:05 PDT 
Comment on attachment 400759 [details]
Patch

Removing review bit - sorry, didn't run the S3TC tests locally, so clearly there's a bug.
Comment 5 Kenneth Russell 2020-06-01 19:39:00 PDT 
Created attachment 400777 [details]
Patch
Comment 6 Dean Jackson 2020-06-02 16:06:48 PDT 
Checked on iOS hardware.
Comment 7 EWS 2020-06-02 16:18:07 PDT 
Committed r262460: <https://trac.webkit.org/changeset/262460>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400777 [details].
Comment 8 Radar WebKit Bug Importer 2020-06-02 16:19:16 PDT 
<rdar://problem/63897758>
Comment 9 Kenneth Russell 2020-06-02 16:26:05 PDT 
Thanks Dean for validating this on iOS hardware!